feat: (CXSPA-12331) - Listbox semantics for facet component#21249
Merged
feat: (CXSPA-12331) - Listbox semantics for facet component#21249
Conversation
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-12331
|
| Run status |
|
| Run duration | 04m 17s |
| Commit |
|
| Committer | PioBar |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
101
|
| View all changes introduced in this branch ↗︎ | |
uroslates
approved these changes
Mar 17, 2026
Contributor
uroslates
left a comment
uroslates
left a comment
There was a problem hiding this comment.
👍 Tested locally using JAWS and selecting options using arrows now works fine and outlines what is highlighted in the list. Check the attached screenshot:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://jira.tools.sap/browse/CXSPA-12331
The links in facets should be contained in a listbox. This way we ensure JAWS does not override keyboard controls and
visible-focusoutline will be visible. PR Includes attribute changes to improve JAWS output as well.This issue needs a screen reader to be reviewed. Please, ensure the outline is visible while JAWS is on and the reader output is satisfactory.