-
Notifications
You must be signed in to change notification settings - Fork 43
Migrate Work from release/SBN2025A to develop #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jas1005
wants to merge
97
commits into
develop
Choose a base branch
from
migrate/SBN2025A
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
97 commits
Select commit
Hold shift + click to select a range
30c60b1
Updating dependencies
84f703d
Updating dependencies
08fcd01
The gauss hit finder operating on ChannelROIs has moved to sbncode, a…
SFBayLaser 27b6b78
Updated icarus_data and sbncode dependencies
b0ba537
Fix fhicl bugs and update G4 config names.
gputnam 36b81f1
Update SkipTesting list.
gputnam b29e832
Updating sbncode dependency
5ffe503
Ignore another fcl.
gputnam aa230b9
Remove path in new configs in SkipTesting.txt
gputnam 2f0525a
Updating tag and dependencies for release
1551887
Reorganize standard fcls. Update to new MC path. Add in overlay path.
gputnam a095e2d
Fhicl file to convert ChannelROIs back into Wires
gputnam fef5977
Get non-YZ detsim configs working. Add in overlay option to non-YZ sim.
gputnam fd478dd
Tune sim-reco timing offsets to 2D deconv.
gputnam 8c0136d
Add gpus configs
nathanielerowe a6805b1
Revert "Add gpus configs"
nathanielerowe 8f6b363
Update stage0_icarus_defs.fcl
nathanielerowe 36ad784
Create wcls-decode-to-sig-twofaced-dnnroi-gpu.jsonnet
nathanielerowe 850a023
Add partial fcls back into icaruscode
gputnam cc9bd56
Updating version for CMake and ups dependencies
6c36b9c
Delete icaruscode/TPC/ICARUSWireCell/icarus/wcls-decode-to-sig-twofac…
nathanielerowe 25ed5fa
Update stage0_run2_wcdnn_icarus_overlay.fcl
nathanielerowe b16ea59
Create stage0_run2_wcdnn_gpu_icarus.fcl
nathanielerowe 29be32f
Update stage0_icarus_defs.fcl
nathanielerowe 211f903
Prune simChannelROI from 1D SP fcl.
gputnam 16636cf
Simple detsim jsonnet bugfix.
gputnam af17978
Remove mcreco from CAF stage.
gputnam 870ecf7
Stage1+CAF configs for non-YZ detsim.
gputnam 71e04e8
Ignore mcreco logging.
gputnam 73b9961
Correctly disable mcreco logging.
gputnam 3dc5615
Disable pusle trains.
gputnam 02ae7a8
Move from overlay to mc
nathanielerowe 6311443
Updating version
b293dca
Fixup GPU enabled WC DNN configs. Move cpu setting into default fcl.
gputnam c169b76
Updating the package version
2a3ce4f
keep PMT waveforms in stage and add fcl to drop them later
cerati efe6520
no additional timestamp in file name
cerati 577da27
Updated CMake tag for icarus release
04194fb
Inject services necessary for metadata generation in production.
gputnam 6f6e6f2
Updating CMake tag
9e34864
Update overlay reco to use same calibrations as data reco.
gputnam cf147dd
Update calibrations for 2D+DNN signal processing for Run 2.
gputnam 9acee10
Update reco1 processing chain. Pandora gets hits with 'long hits', co…
gputnam e4f996b
Tune transverse diffusion constant.
gputnam 6bc393a
Tune MC gain and sim-reco timing offsets.
gputnam 24270ba
Fix stage0 mc no trigger simulation fcl file.
gputnam 2ab066e
Update to new YZ gain map.
gputnam 124bec2
Revert "Tune transverse diffusion constant."
gputnam 3e117bb
MC gain fine tuning.
gputnam 95be875
Set reco gain values.
gputnam 202fed7
Update CMake and product dependency
b52c99c
Corrected icarusalg version
27c43aa
Remove CaloConst override in CAF.
gputnam 798f36c
Tag for production release
527aaa0
Put supera config in icaruscode with correct SimChannel input. Overri…
gputnam c9238a7
Add in overlay supera config with correct CRT label.
gputnam ad8f8d4
Set overload path correctly...
gputnam b6d0788
CMake tag for release
047e425
Fixes to overlay CAF files. Use correct truth labels. Don't blind ove…
gputnam e4a1d5e
GENIE gen config with fiducial cut.
gputnam eb9be52
Fix output supera CRT hit label.
gputnam be93c12
Updated Cmake tag
c6b5e2b
Update products to save. Keep DAQ CRT hits and PMT waveforms. Drop MC…
gputnam 9ee8748
Put product update into 1D SP stage0 reco.
gputnam a335a79
Make sure to move the tag!
SFBayLaser 5ca2775
Use correct CRT Hit label in CAF making.
gputnam dba9b05
New fcl files to enable Overlay pathway for Wiremod sample.
gputnam 644eecd
Add geant4 into CAFMaker defs
dcda07d
Add G4Rewight configs to cafmaker
c69f596
Update sbncode dependency to get G4RW support
858fa9f
Mash G4RW into all systtools cafmakerjobs
76d5f75
Fix hit labels for new hit merging.
gputnam 9d3245c
Set correct CRTSimChannel override for refactored detsim.
gputnam 4b1e4c9
Update standard overlay+data reco fcl files to 2D SP.
gputnam 09834c6
Updated CMake and product dependencies
ac527c7
This commit re-introduces CRTData in Stage0.
4a4bc73
Updated CMake tag
33ee54f
update pmt tags
mvicenzi c0e625d
fix to stage1 1D deconvolution
francescopoppi e3aded1
removal of keepup fcl, changed icarus_filter1D_cluster3D to original.
francescopoppi 1b2c8bc
stage1_run2_1d_icarus updated to work with Cluster3D
francescopoppi 049a1f5
stage1_run2_1d_icarus, fix typo
francescopoppi aa0fbf1
tested and works. caloskimE/W are analyzers, not producers.
d8bb948
BugFix: If CRTData are not present, hitTreeun number and subRun numbe…
francescopoppi b211c76
The code was fairly unreadable. Added indentention for readibility an…
francescopoppi f1def6d
Update icarus_data dependency. As part of the migration from release/…
mvicenzi e48daf9
This commit does the following things: a) it fixes an issue/typo wher…
638b105
Add in option to control YZMap+Electron lifetime DB from fcl. Add in …
gputnam 97458ea
Update TPC calibration to tag including 2D-based Run2+4 calibrations.
gputnam 3451b85
Add in option to override scaler json file. Correct which json file i…
gputnam d805bd0
Bump TPC channel status DB version
gputnam 65e92c3
Updating version and dependencies for release
b4f84f2
Update SPINE to use 10 hits per pulse train.
gputnam 03c1cfd
addressed requests from reviewers. sequences: icarus_East/WestHits_TP…
francescopoppi ad7c256
Updating icarus_data version
aa88e11
Updating CMake for new production release
194e2b7
Update PMT GlobalTags to Oct2025, which is the latest tag used by SBN…
jas1005 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| physics.producers.cafmaker.CRTHitLabel: overlayCRTHit | ||
|
|
||
| services.BackTrackerService.BackTracker.OverrideRealData: true | ||
| services.ParticleInventoryService.ParticleInventory.OverrideRealData: true | ||
|
|
||
| physics.producers.cafmaker.OverrideRealData: true | ||
| physics.producers.cafmaker.CreateBlindedCAF: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| #include "cafmakerjob_icarus.fcl" | ||
| #include "cafmaker_add_detsim2d_icarus.fcl" | ||
|
|
||
| services.BackTrackerService.BackTracker.OverrideRealData: true | ||
| services.ParticleInventoryService.ParticleInventory.OverrideRealData: true | ||
| # overwrite the producers to use data versions | ||
| physics.producers: @local::caf_preprocess_data_producers | ||
| physics.runprod: [ @sequence::caf_preprocess_data_sequence, cafmaker] | ||
|
|
||
| physics.producers.cafmaker.OverrideRealData: true | ||
| #include "cafmaker_add_detsim2d_icarus.fcl" | ||
| #include "cafmaker_add_overlay_icarus.fcl" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #include "cafmakerjob_icarus_detsim2d_overlay.fcl" | ||
|
|
||
| physics.producers.cafmaker.SimChannelLabel: "daq:simpleSC" | ||
| services.BackTrackerService.BackTracker.SimChannelModuleLabel: "daq:simpleSC" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #include "cafmakerjob_icarus_detsim2d.fcl" | ||
|
|
||
| physics.producers.cafmaker.SimChannelLabel: "daq:simpleSC" | ||
| services.BackTrackerService.BackTracker.SimChannelModuleLabel: "daq:simpleSC" |
11 changes: 8 additions & 3 deletions
11
fcl/caf/cafmakerjob_icarus_detsim2d_systtools_and_fluxwgt_overlay.fcl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,10 @@ | ||
| #include "cafmakerjob_icarus_detsim2d_systtools_and_fluxwgt.fcl" | ||
|
|
||
| services.BackTrackerService.BackTracker.OverrideRealData: true | ||
| services.ParticleInventoryService.ParticleInventory.OverrideRealData: true | ||
| physics.producers.cafmaker.OverrideRealData: true | ||
| # overwrite the producers to use data versions | ||
| physics.producers: @local::caf_preprocess_data_producers | ||
| physics.runprod: [ @sequence::caf_preprocess_data_sequence, rns, systtools, geant4weight, fluxweight, cafmaker] | ||
|
|
||
| physics.producers.cafmaker.SystWeightLabels: ["systtools", "geant4weight", "fluxweight"] | ||
|
|
||
| #include "cafmaker_add_detsim2d_icarus.fcl" | ||
| #include "cafmaker_add_overlay_icarus.fcl" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #include "cafmakerjob_icarus_sce.fcl" | ||
|
|
||
| physics.runprod: [ @sequence::caf_preprocess_sce_sequence, rns, systtools, cafmaker ] | ||
| physics.runprod: [ @sequence::caf_preprocess_sce_sequence, rns, systtools, geant4weight, cafmaker ] | ||
|
|
||
| physics.producers.cafmaker.SystWeightLabels: ["systtools"] | ||
| physics.producers.cafmaker.SystWeightLabels: ["systtools", "geant4weight"] | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #include "cafmakerjob_icarus_sce.fcl" | ||
|
|
||
| physics.runprod: [ @sequence::caf_preprocess_sce_sequence, rns, systtools, fluxweight, cafmaker ] | ||
| physics.runprod: [ @sequence::caf_preprocess_sce_sequence, rns, systtools, geant4weight, fluxweight, cafmaker ] | ||
|
|
||
| physics.producers.cafmaker.SystWeightLabels: ["systtools", "fluxweight"] | ||
| physics.producers.cafmaker.SystWeightLabels: ["systtools", "geant4weight", "fluxweight"] | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #include "cafmakerjob_icarus.fcl" | ||
|
|
||
| physics.runprod: [ @sequence::caf_preprocess_sequence, rns, systtools, cafmaker ] | ||
| physics.runprod: [ @sequence::caf_preprocess_sequence, rns, systtools, geant4weight, cafmaker ] | ||
|
|
||
| physics.producers.cafmaker.SystWeightLabels: ["systtools"] | ||
| physics.producers.cafmaker.SystWeightLabels: ["systtools", "geant4weight"] | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #include "cafmakerjob_icarus.fcl" | ||
|
|
||
| physics.runprod: [ @sequence::caf_preprocess_sequence, rns, systtools, fluxweight, cafmaker ] | ||
| physics.runprod: [ @sequence::caf_preprocess_sequence, rns, systtools, geant4weight, fluxweight, cafmaker ] | ||
|
|
||
| physics.producers.cafmaker.SystWeightLabels: ["systtools", "fluxweight"] | ||
| physics.producers.cafmaker.SystWeightLabels: ["systtools", "geant4weight", "fluxweight"] | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #include "detsim_2d_icarus_refactored.fcl" | ||
|
|
||
| physics.producers.daq: @local::icarus_simwire_wirecell_shifted_overlay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #include "detsim_2d_icarus_refactored_yzsim.fcl" | ||
|
|
||
| physics.producers.daq.wcls_main.params.YZScaleMapJson: "yzmap_gain_icarus_v4_run4.json" |
3 changes: 3 additions & 0 deletions
3
fcl/detsim/detsim_2d_icarus_refactored_yzsim_overlay_Run4.fcl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #include "detsim_2d_icarus_refactored_yzsim_overlay.fcl" | ||
|
|
||
| physics.producers.daq.wcls_main.params.YZScaleMapJson: "yzmap_gain_icarus_v4_run4.json" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| #include "filter_wiremod_sbn.fcl" | ||
| #include "larg4_icarus_cosmics_sce.fcl" | ||
|
|
||
|
|
||
| # Insert the sim channel filter and only save events that pass it | ||
| physics.filters.requiresimchan: @local::filter_primary_simchan | ||
| physics.simulate: [@sequence::physics.simulate, "requiresimchan"] | ||
| outputs.rootoutput.SelectEvents: ["simulate"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| #include "corsika_icarus.fcl" | ||
| #include "beamgates_icarus.fcl" | ||
| #include "services_common_icarus.fcl" | ||
| #include "services_icarus_simulation.fcl" | ||
| #include "wiremodmuon_sbn.fcl" | ||
|
|
||
| process_name: WireModMuon | ||
|
|
||
| services: | ||
| { | ||
| #FileCatalogMetadata: @local::art_file_catalog_mc | ||
| @table::icarus_gen_services | ||
| } | ||
|
|
||
| #Start each new event with an empty event. | ||
| source: | ||
| { | ||
| module_type: EmptyEvent | ||
| timestampPlugin: { plugin_type: "GeneratedEventTimestamp" } | ||
| maxEvents: 10 # Number of events to create | ||
| firstRun: 1 # Run number to use for this file | ||
| firstEvent: 1 # number of first event in the file | ||
| } | ||
|
|
||
| # Define and configure some modules to do work on each event. | ||
| # First modules are defined; they are scheduled later. | ||
| # Modules are grouped by type. | ||
| physics: | ||
| { | ||
|
|
||
| producers: | ||
| { | ||
| generator: { | ||
| @table::icarus_corsika_cmc | ||
| @table::wiremodmuon_icarus | ||
| } | ||
| beamgate: @local::icarus_standardbeamgate_BNB # from beamgates_icarus.fcl | ||
| rns: { module_type: "RandomNumberSaver" } | ||
| } | ||
|
|
||
| #define the producer and filter modules for this path, order matters, | ||
| #filters reject all following items. see lines starting physics.producers below | ||
| simulate: [ rns, generator, beamgate ] | ||
|
|
||
| #define the output stream, there could be more than one if using filters | ||
| stream1: [ out1 ] | ||
|
|
||
| #trigger_paths is a keyword and contains the paths that modify the art::event, | ||
| #ie filters and producers | ||
| trigger_paths: [simulate] | ||
|
|
||
| #end_paths is a keyword and contains the paths that do not modify the art::Event, | ||
| #ie analyzers and output streams. these all run simultaneously | ||
| end_paths: [stream1] | ||
| } | ||
|
|
||
| #block to define where the output goes. if you defined a filter in the physics | ||
| #block and put it in the trigger_paths then you need to put a SelectEvents: {SelectEvents: [XXX]} | ||
| #entry in the output stream you want those to go to, where XXX is the label of the filter module(s) | ||
| outputs: | ||
| { | ||
| out1: | ||
| { | ||
| module_type: RootOutput | ||
| fileName: "prodwiremod_standard_icarus_%tc-%p.root" | ||
| dataTier: "simulated" | ||
| compressionLevel: 1 | ||
| fastCloning: false | ||
| saveMemoryObjectThreshold: 0 | ||
| } | ||
| } | ||
|
|
||
| # Allow info messages from generator | ||
| # services.message.destinations.LogStandardOut.categories.WireModMuon.limit: 0 | ||
|
|
||
| services.TFileService.fileName: "Supplemental-prodwiremod_standard_icarus_%tc-%p.root" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #include "prodwiremod_icarus.fcl" | ||
|
|
||
| #include "enable_overlay_gen.fcl" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
fcl/overlays/simulation_genie_icarus_bnb_overlays_volDetEnclosure_fiducial.fcl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #include "simulation_genie_icarus_bnb_overlays_volDetEnclosure.fcl" | ||
|
|
||
| physics.producers.generator.FiducialCut: "mbox: -378.49,-191.86,-904.950652270838,378.49,144.96,904.950652270838" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In CMake,
set(${PROJECT_NAME}_CMAKE_PROJECT_VERSION_STRING ...)is executed beforeproject(...), soPROJECT_NAMEis not defined yet and this sets the wrong variable (often_CMAKE_PROJECT_VERSION_STRING). This can break version propagation/packaging; seticaruscode_CMAKE_PROJECT_VERSION_STRINGexplicitly or restoreproject(icaruscode VERSION ...)and drop the manualset().