X-ARAPUCA Offline Decoder Update: combination of the extended fragments

[aliciavr]

Description

• Implements the combination of the extended fragments in the X-ARAPUCA offline decoder.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

• Added at least 1 label from available labels.
• Assigned at least 1 reviewer under Reviewers,
• Assigned all contributers including yourself under Assignees
• Linked any relevant issues under Developement
• [] Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
• Does this affect the standard workflow?
• Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added? SBN-doc-44578.

[lynnt20]

Hi Alicia! Nice work! I took a look at the decode/combine waveform functions, and it looks to me like the only check of whether to combine two waveforms is a length check. We might want to additionally require that the timestamps of the extensions are compatible with the waveform that you're trying to combine it with... in all normal cases this should be true but it doesn't hurt to have an explicit check I think.

[nathanielerowe]

@aliciavr Can you respond to this follow up q? Thanks!

[aliciavr]

Working on that thank you!

[nathanielerowe]

@aliciavr deadline for validation ii is in a few days, if you are interested in getting this in please wrap up work soon!

[aliciavr]

Just finished implementing the new timing requirements for the combination of extended fragments! A different approach has been followed for the XAs case as discussed offline

[nathanielerowe]

For record keeping purposes, more details in https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=44578

[nathanielerowe]

@aliciavr any updates on the state of this PR?

[aliciavr]

@nathanielerowe All done on my side! Thanks! :)

[nathanielerowe]

@aliciavr thanks! @lynnt20 @jicrespo can ya'll take a look at this then?

[nathanielerowe]

Approved by Jose over slack

[nathanielerowe]

trigger build ci_ref=v10_14_02_03 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_03

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[nathanielerowe]

Approved