Conversation
|
Adding a comment to each of these to track all 4 related PR. The changes to sbnobj, and sbnanaobj are fully independent of any other changes, so they can be approved first. sbndcode changes rely on sbnobj, so it will have to wait for the first approval. A later simple PR will delete the (now duplicated) class files in the BlipUtils folder here sbncode changes rely on both sbnobj and sbnanaobj, so that will have to wait for both of the first two approvals. |
|
Hi @Jjm321814 can you remove the CRT changes from this PR and instead merge in |
|
Merged in develop. Testing Compile now |
|
Compiled fine |
|
Let me make fcl changes to the cafmaker, but a dumped fcl version worked fine |
|
Pushed all the fcl changes needed to run CAF on data and MC. |
|
Hi Jacob, I will review properly after tomorrow's reconstruction meeting. In the meanwhile there are still changes to CRT and LightPropagation files that shouldn't be necessary. Can you remove these? Thanks! |
|
I fixed the merge conflict. |
|
@Jjm321814 Any unmerged PRs for SBN repositories will need to be duplicated. We split off production/sbnd-gen2 following the v10_14_02_02 release, so anything already merged in should be fine. The sbnobj PR mentioned in this description will need to have a separate copy as well. The branch naming convention should be unified for production branches this time around. Apologies for the inconvenience, I put the split off as long as I could. |
|
Okay I am make those duplication. To be clear on the 3-related PR in sbncode, sbnobj, and sbnanaobj do I also need to make duplications? |
|
Yeah, unfortunately 3 more PRs will need to be opened |
|
Made copies of all the PR. I tagged Nate as reviewer for each, but the actual reviews should be done in the PR to develop. |
|
@Jjm321814 We are still waiting on approval from Gianluca, I will reach out to him again. |
|
@Jjm321814 He says this one is good to go, but some of the dependencies need some minor changes. |
|
Approved by Gianluca over slack |
|
Outputs of cafmaker look good after all updates |
|
All the comments should be addressed now |
|
trigger build ci_ref=v10_14_02_03 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
trigger build ci_ref=v10_14_02_03 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbnobj#155 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
@Jjm321814 Does this require sequential CI tests? In other words, do data product dependencies between stages change with this PR? |
|
So this definitely needs the sbnobj branch from the other R, but it looks like thats being imported in to your tests. I think it would be most easily tested as |
|
@Jjm321814 cafmaker does get run, I will include the PRs listed in one of your follow up comments. |
|
trigger build ci_ref=v10_14_02_03 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbncode#603 SBNSoftware/sbnanaobj#173 SBNSoftware/sbnobj#155 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
7 participants
Moved the blip-related structs and classes to sbnobj.
This PR must not be approved until SBNSoftware/sbnobj#155 is approved/released! Otherwise it will break blip production.
I also had to make a few CRT changes to successfully compile off the current sbnobj file.
https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=44445