Pandora CI cluster metrics

[AndyChappell]

Description

This pull request adds new fcl and Pandora XML configurations to support direct production of Pandora metrics within the continuous integration system. Provisionally, these contain a number of basic cluster metrics (ARI, purity, completeness, etc), but could in principle be extended in the future.

The ci_reco2_sbnd.fcl inherits from standard_reco2_sbnd.fcl and makes the minimal changes to the Pandora configuration for this workflow to run. The PandoraSettings_CI_SBND.xml mirrors the current PandoraSettings_Master_SBND.xml. Unfortunately, because this can't inherit a workflow, so it will be necessary to ensure suitable syncrhonisation between the CI XML and the standard Master XML if the Master XML changes (the CI XML removes the visualisation algorithms and adds the cluster validation algorithm). However, the Master XML is the most stable part of the configuration, and so changes here should be relatively rare.

Checklist

• Added at least 1 label from available labels.
• Assigned at least 1 reviewer under Reviewers,
• Assigned all contributers including yourself under Assignees
• Linked any relevant issues under Developement
• Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
• Does this affect the standard workflow?
• Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

[henrylay97]

Thanks for doing this so quickly @AndyChappell!

Looks great to me, I have one request - could you put a comment line in the top of the Master XML that directs people editing it to make the same edits to the CI XML? Might prevent the future divergence you mention 😄

[AndyChappell]

Done

[nathanielerowe]

Tagging @SabrinaBrickner and @vitodb since it is a CI related PR

[SabrinaBrickner]

Hi @AndyChappell! This looks like a new possible regression test. Does this need to be added to an existing test suite, or will that be done later?

[henrylay97]

Hi @SabrinaBrickner this isn't for a new regression test :) Instead it is to provide metrics that will be utilised in the validation side of the CI system. Sergio (I can't find his github tag) can comment on what the plan for adoption will be :)

[nathanielerowe]

@henrylay97 I reached out to Sergio. I will swap you for Sergio as a reviewer @SabrinaBrickner. For future reference to keep terminology straight we refer to validation and CI as separate steps in the release process.

[SergioYB]

Hi, it's my first PR review so I'm a bit lost here. I installed this branch locally and simulated a few events to test ci_reco2_sbnd.fcl. The output looks good and I have already introduced the new variables to be plotted through the CI system. I cannot run the CI on this branch since there is a version incompatibility with GENIE and the generation fails, but this issue was fixed in v10_14_02_03. Should I do anything else or should I just approve the PR and perform the CI test once this branch is merged?