Light Calorimetry (Production) by lynnt20 · Pull Request #911 · SBNSoftware/sbndcode

lynnt20 · 2026-02-05T16:05:48Z

Description

Identical to #878.

Checklist

Added at least 1 label from available labels.
Assigned at least 1 reviewer under Reviewers,
Assigned all contributers including yourself under Assignees
Linked any relevant issues under Developement
Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
Does this affect the standard workflow?
Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links

Accompanying PRs: SBNSoftware/sbncode#619, SBNSoftware/sbnanaobj#181, SBNSoftware/sbnobj#158

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

Version v09_67_00

- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr

- moved truth validation to a separate function - added lower/upper threshold for PE per channel - added fcl param to turn on/off evaluating all planes - option to add dir/refl efficiencies; NOTE: not really accounted for in the code yet

- merge the two previous trees into one - match-type can now differentiate between event/slice level easily

Version v09_89_01, patch release for SBN2024A

Version v09_93_01_02p02

Version v10_04_07

…nstructable PMTs

…ctable PMTs (use pmt calib db instead)

…tcalorimetry_dev

…to some fcl comments - also remove unused functions

…sed headers

…ing messages; avoid hardcoded TPC tick

This reverts commit 6ff86f1.

…e data fcl configuration

Version v10_14_02_01

nathanielerowe · 2026-02-17T00:39:53Z

trigger build ci_ref=v10_14_02_03 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_03

FNALbuild · 2026-02-17T01:02:09Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-02-17T01:05:00Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-02-17T01:16:19Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-02-17T01:24:53Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

nathanielerowe · 2026-02-17T14:32:39Z

Build failed with

986: /scratch/workspace/sbnd_ci/label_exp/swarm/label_exp2/swarm/SBND/srcs/sbndcode/sbndcode/Calorimetry/LightCaloProducer_module.cc:53:10: fatal error: sbnobj/Common/Reco/LightCalo.h: No such file or directory
5987:    53 | #include "sbnobj/Common/Reco/LightCalo.h"
5988:       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5989: compilation terminated.

nathanielerowe · 2026-02-17T14:33:35Z

Sorry, im being dumb. Running again with dependencies.

nathanielerowe · 2026-02-17T14:34:46Z

trigger build ci_ref=v10_14_02_03 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbncode#619 SBNSoftware/sbnanaobj#181 SBNSoftware/sbnobj#158 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_03

FNALbuild · 2026-02-17T14:49:47Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-02-17T14:52:57Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-02-17T14:59:48Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-02-17T15:14:29Z

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

lynnt20 added 30 commits January 10, 2023 23:58

first build + commit

94c59df

added root tree, more explicit cut parameters, and opflashes

08bd042

first commit of light reco attempt using visibility map

fa2b8a7

working version with reco/true comparisons

ccea7c6

added backtracker info

afea365

cleaned up trees, added wire assn, gamma weighted avg, true hit info

7ed0f0e

clean up truth/reco hit information

31847f3

add calibration constants for all planes

b119273

use all hits instead of spacepoints->hits

55032e6

clean up calorimetry cmakelists

fea4bf4

calculate median as light estimate

477b63a

removed unweighted fcl, added arapucas and noise threshold

eea4729

fix tpc split bug, comitting debugging couts, add mean+median functions

081f01d

cleanup

91ad097

cleanup: remove hardcoded values, add fcl params

2e972c0

Merge tag 'v09_67_00' into feature/lynnt_lightcalorimetry

ab13d13

Version v09_67_00

added verbose + skip truth validation fcl

5a0893c

- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr

added verbose + skip truth validation fcl

bd8b760

- cleaned (but need to clean more) skipping products that aren't used (xarapuca flashes + truth products) for example to avoid nullptr

initial commit of producer module

bf0b0cc

working version of producer module

8411be8

cleanup, new functions, fcl parameters:

52c18df

- moved truth validation to a separate function - added lower/upper threshold for PE per channel - added fcl param to turn on/off evaluating all planes - option to add dir/refl efficiencies; NOTE: not really accounted for in the code yet

update output ttree, fix initialized/dummy ttree variables

a1df52b

- merge the two previous trees into one - match-type can now differentiate between event/slice level easily

Merge tag 'v09_89_01' into feature/lynnt_lightcalorimetry

d21b784

Version v09_89_01, patch release for SBN2024A

switch to correct namespace for photon model, cleanup

16ce241

update opdet efficiencies and simulation values

b791b51

make working version of fcl without the analyzer

543c337

update noise/non-linearity thresholds

2fc9be1

small cleanup

6b59f8e

Merge tag 'v09_93_01_02p02' into feature/lynnt_lightcalorimetry

07bdd70

Version v09_93_01_02p02

Merge tag 'v10_04_07' into feature/lynnt_lightcalorimetry

37a8831

Version v10_04_07

lynnt20 added 16 commits January 22, 2026 11:42

use pmt calibration database instead of fcl param to identify on/reco…

297632a

…nstructable PMTs

update PMT efficiencies to latest, remove hardcoded off/non-reconstru…

6432861

…ctable PMTs (use pmt calib db instead)

Merge branch 'feature/lynnt_lightcalorimetry' into feature/lynnt_ligh…

193666b

…tcalorimetry_dev

inherit efficiency, tpc constants from their initial fcls; add units …

7fe5bab

…to some fcl comments - also remove unused functions

checks opflash producer size instead of assuming both tpcs

8f48fed

add fcl param on whether to fill TTree, add more comments, remove unu…

18876a7

…sed headers

cleanup unused includes and dependencies

8dff5ed

add initial filename/timestamp info on the output art file

916b861

update LightCaloProducer to conditionally fill TTree and enhance logg…

2e219b7

…ing messages; avoid hardcoded TPC tick

Revert "Update to larsoft v10_14_02"

2bfc1df

This reverts commit 6ff86f1.

Add electron lifetime database support to LightCaloProducer and updat…

eb1a3a9

…e data fcl configuration

Merge tag 'v10_14_02_01' into feature/lynnt_lightcalorimetry

68d3ab0

Version v10_14_02_01

order matters for reco workflow includes!

81a67e8

update CMake dependences for TPC calibdb

d6b3270

fix some elifetime bugs

1a5e851

move electron lifetime retrieval to avoid duplication during slice loop

da3ae91

nathanielerowe self-requested a review February 13, 2026 17:07

nathanielerowe approved these changes Feb 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Light Calorimetry (Production)#911

Light Calorimetry (Production)#911
lynnt20 wants to merge 89 commits intoproduction/sbnd-gen2from
feature/lynnt_lightcalorimetry

lynnt20 commented Feb 5, 2026

Uh oh!

nathanielerowe commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

nathanielerowe commented Feb 17, 2026

Uh oh!

nathanielerowe commented Feb 17, 2026

Uh oh!

nathanielerowe commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

lynnt20 commented Feb 5, 2026

Description

Checklist

Relevant PR links

Link(s) to docdb describing changes (optional)

Uh oh!

nathanielerowe commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

nathanielerowe commented Feb 17, 2026

Uh oh!

nathanielerowe commented Feb 17, 2026

Uh oh!

nathanielerowe commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

FNALbuild commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments