Conversation
|
Thank you @Sichao25 . Regarding the pre-processor issue, does the following SO post help? |
|
Unfortunately, that SO doesn't work on my side. However, I was able to get things working by ignoring the SWIG unrecognized code during compilation and implementing it in another way in the SWIG interface file. (Thanks to Aiden for the idea and resources!) I've added the required template initialization to the PR. I could also implement a similar But I'm not sure if it's worth the effort, since I feel like it would be relatively straightforward to achieve the same functionality in Python. Do you think it makes sense to skip the |
|
My opinion is skip |
|
The changes look good to me and the example is pretty clean. |
…ation realted to macro
|
@cwsmith Does the comment make sense to you? |
cwsmith
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you.
The Python wrappers have been out of date for some time and were only compatible with older versions of PUMI. This PR addresses several related issues:
.smdfile as an alternative to.x_tto adapt to different versions of Simmetrix.