Fix shaded scoreboard library integration with correct API exposure#94
Open
twisti-dev wants to merge 6 commits intoversion/1.21from
Open
Fix shaded scoreboard library integration with correct API exposure#94twisti-dev wants to merge 6 commits intoversion/1.21from
twisti-dev wants to merge 6 commits intoversion/1.21from
Conversation
Closed
Contributor
Author
|
Obviously a review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of Changes
Resolved an issue where the scoreboard library was incorrectly loaded through the libs loader while its implementation was shaded. The patch ensures proper API exposure and runtime behavior by adjusting the dependency declarations and build configuration.
Details
IDE Configuration Update
CommitFormat,CommitNamingConvention) in.idea/vcs.xmlto enforce consistent commit message formats.Version Bump
gradle.propertiesfrom1.21.4-2.13.3-SNAPSHOTto1.21.4-2.13.4-SNAPSHOTto reflect the patch.Dependency Scope Fix
runtimeOnlytoapiforlibs.scoreboard.library.implementation,libs.scoreboard.library.modern, andlibs.scoreboard.library.apiinsurf-api-bukkit-server/build.gradle.ktsto correctly expose the shaded scoreboard library during compilation and runtime.Motivation
The scoreboard library was improperly configured, causing it to be loaded at runtime but not properly exposed as an API due to shading. This fix aligns the dependency scope to ensure consistent functionality and developer access.
Impact
Testing
Additional Notes
Download Build‑JARs for this PR: pr-built-jars.zip