Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces per-game-mode permission enforcement in command argument parsing and suggestion generation so users can only select/suggest game modes they’re authorized to use.
Changes:
- Added permission checks in
GameModeArgumentforsurf.essentials.gameMode.<gamemode>. - Filtered game mode tab-completions to only show permitted modes.
- Registered new per-mode permission nodes and bumped the project version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/kotlin/dev/slne/surf/essentials/util/permission/EssentialsPermissionRegistry.kt | Adds new permission nodes for each game mode in the permission registry. |
| src/main/kotlin/dev/slne/surf/essentials/command/argument/GameModeArgument.kt | Enforces per-mode permission checks during parsing and filters suggestions based on permissions. |
| gradle.properties | Bumps snapshot version to 1.21.11-2.0.11-SNAPSHOT. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/kotlin/dev/slne/surf/essentials/util/permission/EssentialsPermissionRegistry.kt
Show resolved
Hide resolved
src/main/kotlin/dev/slne/surf/essentials/command/argument/GameModeArgument.kt
Show resolved
Hide resolved
src/main/kotlin/dev/slne/surf/essentials/command/argument/GameModeArgument.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces permission checks for selecting game modes and refines the command suggestion system to only show game modes the user has access to. It also adds new permission entries for each game mode in the permission registry and bumps the project version.
Permission system improvements:
GameModeArgumentto ensure that users can only select game modes for which they have the appropriatesurf.essentials.gameMode.<gamemode>permission. If the user lacks permission, a specific error message is shown.GameModeArgumentto only display modes the sender has permission to use.Permission registry updates:
EssentialsPermissionRegistryfor each game mode:creative,survival,adventure, andspectator.Version update:
1.21.11-2.0.10-SNAPSHOTto1.21.11-2.0.11-SNAPSHOTingradle.properties.