Fix bug in mono-buffer.fun introduced by 8d5681c#36
Open
MatthewFluet wants to merge 1 commit intoSMLFamily:masterfrom
Open
Fix bug in mono-buffer.fun introduced by 8d5681c#36MatthewFluet wants to merge 1 commit intoSMLFamily:masterfrom
MatthewFluet wants to merge 1 commit intoSMLFamily:masterfrom
Conversation
The intention of 8d5681c was to double the buffer size when `ensureCapacity` must grow the buffer, but mistakenly doubled the buffer size every time `ensureCapacity` was called, leading to an uncaught `Overflow` exception after sufficient operations that call `ensureCapacity` before adding content to the buffer. See MLton/mlton#608.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intention of 8d5681c was to double the buffer size when
ensureCapacitymust grow the buffer, but mistakenly doubled the buffer size every timeensureCapacitywas called, leading to an uncaughtOverflowexception after sufficient operations that callensureCapacitybefore adding content to the buffer.See MLton/mlton#608.