use std namespace for int types under cstdint#536
use std namespace for int types under cstdint#536UnixY2K wants to merge 1 commit intoSRombauts:masterfrom
Conversation
|
Maybe there's something I'm missing but if |
|
@dvtate I can't see anything exotic about the toolchain. Already saw such an issue in the past on other projects over the last perhaps 10+ years, But yeah, this is frustrating to not pin-point the root cause. |
|
I'm not seeing that in clang 21 (or any compiler for that matter). Please find a compiler where this doesn't compile: https://godbolt.org/z/4GvEqbGze (for older compilers you may need According to chatgpt the only time that they wouldn't be the same is if that platform doesn't have a 32 bit integer type (unrealistic), in which case std::int32_t wouldn't exist and you'd get a compiler error if you tried to use it. |
|
@dvtate Did you try with the information provided in the issue ? #535 (comment) Sadly, I don't have time for futher investigation. As mentioned, it's already fixed in 3.3.3 anyway. |
integer types under
cstdintare only required to be under thestdnamespace while the global namespace definition is optional.this PR fixes the undefined behavior for the files that assume global namespace availability.