sysdb: Execute override code even if no templates exist#8070
sysdb: Execute override code even if no templates exist#8070justin-stephenson wants to merge 1 commit intoSSSD:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where ID overrides were not being applied if no templates were present. The change correctly removes the else block that caused a premature exit from sysdb_apply_default_override, ensuring that override logic is always executed. Additionally, a misleading comment has been removed, improving code clarity. The fix appears correct and complete, and I have no further suggestions.
|
@justin-stephenson, is this related to #8059? |
Yes. |
|
Added |
Could you please add corresponding "Resolves:" line to the commit message? |
justin-stephenson
force-pushed
the
overrides_default_view_fix
branch
from
5685189 to
861c0b7
Compare
Added, thanks. |
|
@justin-stephenson only backport to 2-9? Not 2-10 2-11? |
https://github.com/SSSD/sssd/pull/7924 was 2-9 backport only was 2-9 only also, I set the same here. |
|
@justin-stephenson, could you please rebase? |
Fixes an issue where ID overrides were not applied properly for the Default Trust View. Resolves: SSSD#8059
justin-stephenson
force-pushed
the
overrides_default_view_fix
branch
from
861c0b7 to
2702adb
Compare
Done. |
4 participants
Fixes an issue where ID overrides were not applied properly for the Default Trust View.