Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a significant refactoring of the memcache tests, aiming to reduce code duplication by introducing helper functions and parametrizing tests. While this is a great improvement for maintainability, the new implementation introduces several critical and high-severity issues, including a syntax error, flawed test logic that would cause failures, and several inconsistencies between test names, docstrings, and their implementations. I've detailed these issues in the review comments.
danlavu
force-pushed
the
tests-rm-memcache
branch
from
88f67f3 to
4164a67
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
danlavu
force-pushed
the
tests-rm-memcache
branch
from
4164a67 to
92e2433
Compare
danlavu
force-pushed
the
tests-rm-memcache
branch
4 times, most recently
from
800149e to
79780ef
Compare
danlavu
force-pushed
the
tests-rm-memcache
branch
2 times, most recently
from
36e1b79 to
757722f
Compare
danlavu
force-pushed
the
tests-rm-memcache
branch
2 times, most recently
from
bc7b7a2 to
b484bad
Compare
|
@danlavu, can you please check, |
* parametrized test cases * added colliding hash test case * remove poor test scenarios
danlavu
force-pushed
the
tests-rm-memcache
branch
from
b484bad to
29ad9e3
Compare
|
@madhuriupadhye @andreboscatto I suggest reviewing this PR using the split diff view and not the unified diff. |
3 participants
No description provided.