Some fixes, ci, cmake ...#1113
Merged
dlyr merged 44 commits intoSTORM-IRIT:release-candidatefrom Mar 23, 2026
Merged
Conversation
Ease the use of make_shared.
Maybe too much ? will see when with usage.
Found by set and check...
This fixes dataflow components that are not lib, install path not consistent. Also try to better handle component and "_FOUND".
Also update doc and cleanup.
Last hash has been deleted...
Seems not consistent anymore between windows and linux.
Might easily fix ci ?
DEPENDS not allowed in custom target.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-candidate #1113 +/- ##
=====================================================
+ Coverage 41.59% 41.83% +0.24%
=====================================================
Files 387 387
Lines 30074 28053 -2021
=====================================================
- Hits 12508 11736 -772
+ Misses 17566 16317 -1249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Also fix typo in comment.
Push a little bit point of triangle for distance query.
add_component_dependency did not work if dep A is added in requested component after dep B which needs dep A (A was not included before B since it checks if A is requested, and only include if not already requested).
MathiasPaulin
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update on ci image use newer cmake.
Pass flags to external.
Update Assimp and QtNodes
Fix build.sh script.
Rework cmake config.
Also rework on typeutils to simplify demangle types, remove space before comma and __cxx11 (inconsistency between windows and gnu).