added the notion of router hierarchy#82
Conversation
Now all routers are automatically added to a list and enabled the use of this.navigate('../other_route') which then takes the parent route to execute navigae on. Not tested but this should also enable this.navigate('../../other/route')
ensure that there are no duplicate routers in the list
|
I found a small bug, will fix tonight and add to this PR |
|
This is simple. I like it. Could you add some tests and squash the commits? |
|
I'll see how I can test this and will squash them when I have some tests. make test-local doesn't run for me. Do you depends on specific browsers? I am on Ubuntu with only Chrome |
|
|
|
Ok that was simple, I had something running on port 3000 ;-) so what do you recommend creating some browser based tests to verify this functionality or unit tests |
|
Yeah, I would put it in browser.js - the other files are more specific. I would put it around the section where it starts testing contextual routers. On Sep 16, 2014, at 4:54 PM, Mark Nijhof notifications@github.com wrote:
|
|
Ok I added 6 tests 3 for history and 3 for hash api with contextual routers. I am having trouble rebasing the commits as there have been updates from master that I had applied as well in the middle of them. Any hints on how to do this properly? |
Now all routers are automatically added to a list and enabled the use of this.navigate('../other_route') which then takes the parent route to execute navigae on. Not tested but this should also enable this.navigate('../../other/route')
added tests and fixed a bug
…omponent into parent_routers
|
I'll fix this differently :) new PR coming up |
|
Yeah the thing to do would be to rebase your branch on master - |
Now all routers are automatically added to a list and enabled the use of this.navigate('../other_route') which then takes the parent route to execute navigate on. Not tested but this should also enable this.navigate('../../other/route'). Works as well with [Link href=../other_route]home[/Link]
|
I added #84 sorry for any confusion |
Now all routers are automatically added to a list and enabled the use of this.navigate('../other_route') which then takes the parent route to execute navigate on. Not tested but this should also enable this.navigate('../../other/route'). Works as well with [Link href="../other_route"]home[/Link]