Skip to content

Modify the project name and optimize the code for bk7239n#7176

Merged
ewoodev merged 6 commits intoSamsung:masterfrom
bekencorp:BK7239N_dev
Mar 12, 2026
Merged

Modify the project name and optimize the code for bk7239n#7176
ewoodev merged 6 commits intoSamsung:masterfrom
bekencorp:BK7239N_dev

Conversation

@Poly-J
Copy link
Copy Markdown
Contributor

@Poly-J Poly-J commented Mar 4, 2026

1.Modify the project name and remove the 'mp' suffix

  • hello_mp ===> hello
  • loadable_apps_mp ===> loadable_apps
  • loadable_all_mp ===> loadable_all
  • xip_all_mp ===> xip_all

2.Optimize some of the internal code at the board level
3.Optimize some configuration items
4.Some bug fix and modification according to the comments of PR review.

Comment on lines +87 to +99
/* Acquire TFM NSC interface lock; on failure log and return HAL_FAIL */
#define TFM_NSC_LOCK_OR_RETURN() do { \
int _tfm_lock_st = tfm_ns_interface_lock(); \
if (_tfm_lock_st != PSA_SUCCESS) { \
dbg("Failed to acquire NSC interface lock\n"); \
return HAL_FAIL; \
} \
} while (0)

#define TFM_NSC_UNLOCK() do { \
tfm_ns_interface_unlock(); \
} while (0)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay if you don't add NSC lock on armino_hal_get_key / armino_hal_get_hash / armino_hal_get_hmac?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay if you don't add NSC lock on armino_hal_get_key / armino_hal_get_hash / armino_hal_get_hmac?

For these interfaces, they are protected uniformly in the tfm_ns_interface. c file's function tfm_ns_interface_dispatch(). @jylee9613

@pcs1265
Copy link
Copy Markdown
Member

pcs1265 commented Mar 5, 2026

Does this PR include changes about PSRAM clock gating?
There is idle power consumption issue and I wonder this fixes the issue.

  • I just read beken's email. It containing fix that issue.

@seokhun-eom24
Copy link
Copy Markdown
Contributor

Please update your PR as there is a conflict due to a recent build-related commit.

@Poly-J
Copy link
Copy Markdown
Contributor Author

Poly-J commented Mar 10, 2026

Please update your PR as there is a conflict due to a recent build-related commit.

@seokhun-eom24 Thank you for your reminder, we are processing it.

jun.pan added 4 commits March 11, 2026 11:06
Add checks to make non-secure calls to secure interfaces to prevent
reentrancy

Signed-off-by: Poly-J <jun.pan@aclsemi.com>
The previous changes to this file introduced some unnecessary
variables, reverting them keeps the logic consistent with before.

Signed-off-by: Poly-J <jun.pan@aclsemi.com>
Modified the logic of some internal packaging scripts

Signed-off-by: Poly-J <jun.pan@aclsemi.com>
Modify the project name and remove the 'mp' suffix

Signed-off-by: Poly-J <jun.pan@aclsemi.com>
@ziliguo ziliguo force-pushed the BK7239N_dev branch 2 times, most recently from 1cc312d to 482bb6b Compare March 11, 2026 08:53
jun.pan added 2 commits March 11, 2026 19:37
- remove unused code
- add pair bond callbacks implementation
- Update internal library

Signed-off-by: Poly-J <jun.pan@aclsemi.com>
Modify the project name and remove the 'mp' suffix

Signed-off-by: Poly-J <jun.pan@aclsemi.com>
@ewoodev ewoodev merged commit bded17f into Samsung:master Mar 12, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants