Skip to content

Add ADR-024 naming compliance report and update naming_exceptions registry#2368

Closed
SatoryKono wants to merge 1 commit intomainfrom
codex/conduct-naming-compliance-audit
Closed

Add ADR-024 naming compliance report and update naming_exceptions registry#2368
SatoryKono wants to merge 1 commit intomainfrom
codex/conduct-naming-compliance-audit

Conversation

@SatoryKono
Copy link
Copy Markdown
Owner

Motivation

  • Provide an auditable compliance artifact for ADR-024 entity-name unification and make allowed exceptions explicit for traceability.
  • Reduce ambiguity during audits by recording ChEMBL-derived exceptions and CLI/provider naming exceptions in the canonical naming_exceptions.yaml registry.

Description

  • Add a named audit report at docs/99-archive/reports/adr-024-naming-audit/naming-compliance-report.md containing executive summary, scorecard, findings, and verification log.
  • Update configs/naming_exceptions.yaml (bumped Last Updated to 2026-02-24) and append an exception_registry section that records derived_entities, pipeline_id_exceptions, legacy_field_exceptions, and deprecated_aliases with locations, statuses, and reasons.
  • Validate the new YAML syntactically and relocate the generated report under docs/99-archive/reports/ for repo cleanliness.

Testing

  • Ran the full architecture test suite with uv run python -m pytest tests/architecture/ -v, which produced 1359 passed, 21 skipped, 1 failed where the single failure is an existing tests formatting check (ruff format) unrelated to these changes.
  • Ran naming-specific checks with uv run python -m pytest tests/architecture/test_naming_conventions.py -v, which passed (3 passed).
  • Executed the terminology lint entrypoint with uv run python scripts/lint_terminology.py src/bioetl/ and --strict, which currently fails due to an AttributeError in the linter integration and therefore is reported as a P2 finding.
  • Attempted uv run python -m import_linter which is unavailable in the environment and is reported as blocked; the new YAML was programmatically yaml.safe_load-validated (success).

Codex Task

@SatoryKono SatoryKono closed this Mar 2, 2026
@SatoryKono SatoryKono deleted the codex/conduct-naming-compliance-audit branch March 2, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant