docs(diagrams): add template and decompose CRITICAL diagrams [ADR-040]#2395
Closed
SatoryKono wants to merge 1 commit intomainfrom
Closed
docs(diagrams): add template and decompose CRITICAL diagrams [ADR-040]#2395SatoryKono wants to merge 1 commit intomainfrom
SatoryKono wants to merge 1 commit intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
Superseded by #2422. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
supersededmarker so historical originals are retained but excluded from automated renders.%%{init:}blocks for new files.Description
docs/02-architecture/mmd-diagrams/_template.mmdwith standardized metadata fields (@status,@view,@parent,@nodes) and theming guidance (no%%{init:}for new files).architecture/*.mmdfiles to include normalized header metadata (%% @status activeand%% @nodes <n>) and recomputed node counts for accuracy.architecture/01a-01c-*,architecture/13a-13d-*,foundation/01a-01c-*,foundation/50a-50c-*) and added%% @view/%% @parentmetadata to each decomposed file.SUPERSEDEDheader (%% @status superseded+%% @superseded-by ...) and updateddocs/02-architecture/mmd-diagrams/README.mdto linkADR-040, list decomposed views, annotate superseded files, and provide a recommended onboarding order.docs/02-architecture/mmd-diagrams/render.shto skip files containing@status supersededso CI rendering excludes historical originals.Testing
grep-based heuristic) across decomposed files and confirmed@nodesmatches the computed unique node counts and all decomposed views are ≤20 nodes (check succeeded).bash -n docs/02-architecture/mmd-diagrams/render.sh) and Python compile check for the lint script (python -m compileall scripts/lint_diagrams.py), both of which succeeded.python scripts/lint_diagrams.pywhich ran (reported "All diagrams pass policy checks" in this environment), noting it reported zero files processed due to environment scope but the script exercised the updated code path.mmdcbut it failed because themmdcbinary is not installed in the execution environment; pre-commit hooks run in this environment also surfaced unrelated repository-wide checks (auto-formatting, missingpip-audit, and root-level VCR cassette placement) which are external to these diagram edits.Codex Task