Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 94 94
Lines 9516 9516
=======================================
Hits 9032 9032
Misses 484 484 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julianlitz
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to remove inheritance the
GMGPolarclass is templated on a certain number of parameters. This is fine for simulations (e.g. gyselalibxx) that want to use the library, but it causes issues for the command line interface. Up to now we used a pointer to a superclass to avoid this problem. However in order to template theLevelon the geometry, the functionsolvewill need to be in the subclass. It is not possible to write an abstract interface for a templated function so this solution will no longer be possible. This PR usesstd::visitto create an instance of theGMGPolarclass. This slows down the compilation as an instance of the class must be created for each configuration that theConfigParserdescribes.Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):