Skip to content

Fetch send page toll only on mount/network-change/submit#706

Open
garyghayrat wants to merge 2 commits intomasterfrom
fix/send-page-rpc-error
Open

Fetch send page toll only on mount/network-change/submit#706
garyghayrat wants to merge 2 commits intomasterfrom
fix/send-page-rpc-error

Conversation

@garyghayrat
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Feb 26, 2026

Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
🔨 Latest commit 8be8a66
🔍 Latest deploy log https://app.netlify.com/projects/jolly-shaw-20fe62/deploys/699ffdd9bd7cc20008ec4fc9
😎 Deploy Preview https://deploy-preview-706--jolly-shaw-20fe62.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

Coverage after merging fix/send-page-rpc-error into master will be

83.69%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts-periphery/src
   UmbraBatchSend.sol100%100%100%100%
   UniswapWithdrawHook.sol100%100%100%100%
umbra-js/src
   ethers.ts74.58%100%58.33%100%
   types.ts50%100%0%100%
umbra-js/src/classes
   KeyPair.ts98.64%96.43%100%100%31–32
   RandomNumber.ts100%100%100%100%
   StealthKeyRegistry.ts100%100%100%100%
   TxHistoryProvider.ts85.19%65%100%96.55%12, 17, 20, 23, 29, 43, 48, 8
   Umbra.ts82.13%74.21%85%86.35%138–139, 160, 233–234, 302, 320–323, 359–360, 391, 406, 409, 416–418, 420–421, 424–425, 450, 450, 450, 452, 452, 452, 454, 454, 454, 454–455, 455, 455–457, 472, 472, 472–473, 477, 480, 500, 518–520, 561, 608, 625, 638–639, 649–650, 664, 672–673, 703–704, 779–780, 783, 786–787, 793–795, 802, 802, 802–805, 840, 842–843, 843–844
umbra-js/src/utils
   cns.ts50%33.33%50%55%33–36, 40, 40, 40, 40, 40–41, 44–46
   constants.ts100%100%100%100%
   ens.ts36.11%25%33.33%40%25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
   utils.ts71.02%63.98%80%74.82%102, 102, 1026–1027, 1039–1040, 118–120, 122–124, 130, 152–153, 179–181, 181, 181–182, 182, 182, 203, 268, 271, 276, 280, 284, 294, 306–311, 313–320, 320, 320, 320, 320, 320, 320–321, 323, 333, 347–348, 348, 348–349, 353–354, 364, 364, 364–366, 368, 384–386, 414, 437, 440, 444, 444–445, 445, 445–446, 446, 448, 452–453, 456–457, 480, 483, 483, 483–485, 515, 517–518, 527, 527, 527–528, 530, 533, 542–543, 584, 601, 601, 601, 630, 652–654, 657, 667, 679, 679, 68, 680, 685, 687–688, 69, 699–703, 716, 718, 769–770, 770, 770–772, 772, 772, 783, 94
umbra-js/test
   testPrivateKeys.ts100%100%100%100%
   utils.ts100%100%100%100%

Copy link
Contributor

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants