Skip to content

[CU-8699zawdx] Introduction of Scorpio UDP#1

Open
igorosky wants to merge 28 commits intomasterfrom
feature/network_scorpio_udp
Open

[CU-8699zawdx] Introduction of Scorpio UDP#1
igorosky wants to merge 28 commits intomasterfrom
feature/network_scorpio_udp

Conversation

@igorosky
Copy link
Copy Markdown
Contributor

@igorosky igorosky commented Jan 7, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces comprehensive UDP networking functionality for the Scorpio project, including low-level UDP sockets, a custom reliable UDP protocol (Scorpio UDP), and supporting utilities for IP addressing and network byte order conversion.

Key Changes:

  • Implementation of basic UDP socket wrapper with send/receive capabilities
  • Custom Scorpio UDP protocol with connection management, stream multiplexing, and reliable/unreliable delivery modes
  • Network utilities including IP address handling and endianness conversion
  • Comprehensive test suite with both real and mock implementations

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/network/udp.cpp Real UDP socket implementation using system calls
src/network/scorpio_udp.cpp Main Scorpio UDP protocol implementation with connection and stream management
src/network/ip.cpp IPv4 address utilities and network byte order conversion
test/network/mock_udp.cpp Mock UDP implementation for testing with simulated delay and packet loss
test/network/test_*.cpp Comprehensive test suite for UDP components
include/scorpio_utils/threading/jthread.hpp Enhanced thread destructor to handle self-joining
include/scorpio_utils/optional_utils.hpp Simplified optional value extraction using dereference operator
include/scorpio_utils/network/*.hpp Header files defining UDP socket, Scorpio UDP, IP, and network type interfaces
CMakeLists.txt Build configuration updates for new network library and tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/scorpio_utils/threading/jthread.hpp
Comment thread src/network/scorpio_udp.cpp Outdated
Comment thread src/network/scorpio_udp.cpp Outdated
Comment thread src/network/scorpio_udp.cpp Outdated
Comment thread src/network/scorpio_udp.cpp Outdated
Comment thread src/network/scorpio_udp.cpp
Comment thread src/network/scorpio_udp.cpp Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/scorpio_utils/optional_utils.hpp
Comment thread include/scorpio_utils/optional_utils.hpp
Comment thread include/scorpio_utils/optional_utils.hpp
Comment thread include/scorpio_utils/optional_utils.hpp
Comment thread include/scorpio_utils/misc.hpp Outdated
Comment thread include/scorpio_utils/network/types.hpp
Comment thread src/network/scorpio_udp.cpp Outdated
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
@igorosky igorosky force-pushed the feature/network_scorpio_udp branch from 6d1d6ce to ae815b0 Compare February 4, 2026 22:55
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
@igorosky igorosky force-pushed the feature/network_scorpio_udp branch from 91212e1 to 913d281 Compare February 20, 2026 23:06
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
The issue with scorpio_udp is something with heartbeats/retransmission

Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants