Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces comprehensive UDP networking functionality for the Scorpio project, including low-level UDP sockets, a custom reliable UDP protocol (Scorpio UDP), and supporting utilities for IP addressing and network byte order conversion.
Key Changes:
- Implementation of basic UDP socket wrapper with send/receive capabilities
- Custom Scorpio UDP protocol with connection management, stream multiplexing, and reliable/unreliable delivery modes
- Network utilities including IP address handling and endianness conversion
- Comprehensive test suite with both real and mock implementations
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/network/udp.cpp | Real UDP socket implementation using system calls |
| src/network/scorpio_udp.cpp | Main Scorpio UDP protocol implementation with connection and stream management |
| src/network/ip.cpp | IPv4 address utilities and network byte order conversion |
| test/network/mock_udp.cpp | Mock UDP implementation for testing with simulated delay and packet loss |
| test/network/test_*.cpp | Comprehensive test suite for UDP components |
| include/scorpio_utils/threading/jthread.hpp | Enhanced thread destructor to handle self-joining |
| include/scorpio_utils/optional_utils.hpp | Simplified optional value extraction using dereference operator |
| include/scorpio_utils/network/*.hpp | Header files defining UDP socket, Scorpio UDP, IP, and network type interfaces |
| CMakeLists.txt | Build configuration updates for new network library and tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ed6ad07 to
088ca63
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
6d1d6ce to
ae815b0
Compare
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
91212e1 to
913d281
Compare
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
The issue with scorpio_udp is something with heartbeats/retransmission Signed-off-by: igorosky <igor.zaworski2@gmail.com>
Signed-off-by: igorosky <igor.zaworski2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.