Generate valid JS for multi-line setting#263
Merged
renatgalimov merged 1 commit intomasterfrom Sep 29, 2025
Merged
Conversation
90e76f9 to
182f19d
Compare
In v1.0.4, if you have a multi-line string in settings, it will generate an invalid JS. We use serde_json to ensure that the content we build it a valid JSON. We use a JS parser to check the generated JS in tests.
182f19d to
9c0659f
Compare
sergey-borovkov
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v1.0.4, if you have a multi-line string in settings, it will generate an invalid JS.
We use serde_json to ensure that the content we build it a valid JSON. We use a JS parser to check the generated JS in tests.
Before this fix it would generate multi-line settings as:
How has this been tested?
Checklist before merging