create stored_saving_location if not existing, fallback to saving_location on error#297
Open
VeldoraTheDragon wants to merge 3 commits intoSeaDve:mainfrom
Conversation
Owner
|
Hi, thanks for the PR, and sorry for the very late response |
SeaDve
reviewed
Jul 17, 2024
SeaDve
reviewed
Jul 17, 2024
…ut of impl Settings
Owner
|
The failing ci is btw unrelated to this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the default directory
Koohagets created, if it's not existing.However if a different directory is being set via dbus-option e.g
saving-location=b'/home/{{ USERNAME }}/Screencasts'in corporate organizations via config-management, the directory doesn't get created automatically, instead it fails in an error.This PR fixes this issue, by moving:
further up and expanding
!stored_saving_location.as.os.str().is_empty()with.where a fallback to
saving_locationis set, in case it fails to create the directory set viasaving-locationoption.I've tested it on an Arch Linux machine by building it via a modified PKGBUILD of the official PKGBUILD and it worked flawlessly in my case.