Feat/file dialog handler by yy-2020 · Pull Request #1 · Sebbstar/CefSharp.OutOfProcess

yy-2020 · 2023-01-25T09:28:49Z

No description provided.

Sebbstar · 2023-01-30T07:12:26Z

CefSharp.OutOfProcess.WinForms/CefSharp.OutOfProcess.WinForms.csproj


  <PropertyGroup>
    <TargetFrameworks>netcoreapp3.1;net462</TargetFrameworks>
+    <PlatformTarget>AnyCPU</PlatformTarget>


not necessary

Sebbstar · 2023-01-30T07:12:54Z

CefSharp.OutOfProcess.Wpf.HwndHost/ChromiumWebBrowser.cs

            set { SetValue(WebBrowserProperty, value); }
        }

+        Handler.IDialogHandler IChromiumWebBrowser.DialogHandler { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }


no exception, just auto property

Sebbstar · 2023-01-30T07:13:05Z

CefSharp.OutOfProcess.WinForms/ChromiumWebBrowser.cs

        /// <inheritdoc/>
        public Frame MainFrame => _devToolsContext == null ? null : _devToolsContext.MainFrame;

+        Handler.IDialogHandler IChromiumWebBrowser.DialogHandler { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }


use auto property

Sebbstar · 2023-01-30T07:13:51Z

CefSharp.OutOfProcess.Core/CefSharp.OutOfProcess.Core.csproj


  <PropertyGroup>
    <TargetFramework>netstandard2.0</TargetFramework>
+    <PlatformTarget>AnyCPU</PlatformTarget>


not necessary

Sebbstar · 2023-01-30T07:14:05Z

CefSharp.OutOfProcess.Core/CefSharp.OutOfProcess.Core.csproj

    <PackageReference Include="StreamJsonRpc" Version="2.11.35" />
    <ProjectReference Include="..\CefSharp.OutOfProcess.Interface\CefSharp.OutOfProcess.Interface.csproj" />
-
    <ProjectReference Include="..\CefSharp.Dom\lib\PuppeteerSharp\CefSharp.Dom.OutOfProcess.csproj" />


missing line :)

Sebbstar · 2023-01-30T07:16:25Z

CefSharp.OutOfProcess.Wpf.HwndHost/CefSharp.OutOfProcess.Wpf.HwndHost.csproj


  <PropertyGroup>
    <TargetFrameworks>netcoreapp3.1;net462</TargetFrameworks>
+    <PlatformTarget>AnyCPU</PlatformTarget>


Sebbstar · 2023-01-30T07:17:27Z

CefSharp.OutOfProcess.Core/CallbackProxies/CallbackProxyBase.cs

+            {
+                if (disposing)
+                {
+                    // TODO: dispose managed state (managed objects)


remove todos?

Sebbstar · 2023-01-30T07:17:40Z

CefSharp.OutOfProcess.Core/CallbackProxies/CallbackProxyBase.cs

+
+        void IDisposable.Dispose()
+        {
+            // Do not change this code. Put cleanup code in 'Dispose(bool disposing)' method


remove comment

CefSharp.OutOfProcess.BrowserProcess/CallbackProxies/DialogHandlerProxy.cs

Sebbstar · 2023-01-30T12:56:38Z

let's try out using devtools

        private void WaitForFile()
        {
            _devToolsContext.WaitForFileChooserAsync(new WaitForFileChooserOptions() { Timeout = 0 }).ContinueWith(async t =>
            {
                FileChooser filec = t.Result;

                // retrieve accept value
                // show our WPF filedialog
                // return dialogs result
                await filec.AcceptAsync(@"C:\_dev\trumpf\file.html");

                WaitForFile();
            });
        }

yy-2020 added 4 commits January 24, 2023 09:45

file dialog handler

29a02f6

remove references to cefsharp.common

2b66648

restore netstandard2.0

fb4eb7f

use getbrowser method

85ca0fe

Sebbstar requested changes Jan 30, 2023

View reviewed changes

code review changes

442be3c

Conversation

yy-2020 commented Jan 25, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Sebbstar commented Jan 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants