[Javascript] Delete dead atoms that won't work in browsers#17227
Open
AutomatedTester wants to merge 6 commits intotrunkfrom
Open
[Javascript] Delete dead atoms that won't work in browsers#17227AutomatedTester wants to merge 6 commits intotrunkfrom
AutomatedTester wants to merge 6 commits intotrunkfrom
Conversation
This deletes code that have been removed from the web platform. These dont work anywhere so removing them as part of the plan to move the atoms to typescript
selenium-ci
added
C-java
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy JavaScript “atoms” and related WebDriver command plumbing for deprecated/removed web platform features (AppCache, WebSQL, legacy storage endpoints, and related geolocation/connection commands), aligning the codebase with modern browser capabilities and the planned TypeScript migration.
Changes:
- Deletes dead JS atoms (storage/appcache/WebSQL/geolocation helpers) and their Bazel build targets/fragments.
- Removes legacy command constants and codec handling for the deleted features (JS + Java remote command layers).
- Cleans up test fixtures/pages that existed only to exercise the removed HTML5-era functionality.
Reviewed changes
Copilot reviewed 28 out of 32 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| javascript/webdriver/command.js | Removes obsolete command names for deleted browser features. |
| javascript/webdriver/atoms/storage/session_storage.js | Deletes sessionStorage atom wrapper. |
| javascript/webdriver/atoms/storage/local_storage.js | Deletes localStorage atom wrapper. |
| javascript/webdriver/atoms/storage/appcache.js | Deletes AppCache atom wrapper. |
| javascript/webdriver/atoms/inject/sql_database.js | Deletes WebSQL injection atom. |
| javascript/webdriver/atoms/inject/session_storage.js | Deletes sessionStorage injection atom. |
| javascript/webdriver/atoms/inject/local_storage.js | Deletes localStorage injection atom. |
| javascript/webdriver/atoms/inject/appcache.js | Deletes AppCache injection atom. |
| javascript/webdriver/atoms/inject/BUILD.bazel | Removes build targets/fragments for deleted injection atoms. |
| javascript/webdriver/atoms/BUILD.bazel | Stops globbing deleted storage atoms and drops html5 atom dependency/fragments. |
| javascript/selenium-webdriver/lib/test/fileserver.js | Removes routing for deleted HTML5 offline fixture. |
| javascript/chrome-driver/BUILD.bazel | Drops deleted atoms/fragments from ChromeDriver atom bundle. |
| javascript/atoms/html5/storage.js | Deletes html5 storage atom implementation. |
| javascript/atoms/html5/location.js | Deletes geolocation atom implementation. |
| javascript/atoms/html5/html5_browser.js | Deletes html5 feature-detection helper atom. |
| javascript/atoms/html5/database.js | Deletes WebSQL atom implementation. |
| javascript/atoms/html5/appcache.js | Deletes AppCache atom implementation. |
| javascript/atoms/fragments/BUILD.bazel | Removes fragments for execute-sql and get-location. |
| javascript/atoms/BUILD.bazel | Removes the html5 library target and deps. |
| java/test/org/openqa/selenium/environment/webserver/AppServerTestBase.java | Removes AppCache MIME type test tied to deleted fixture. |
| java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpCommandCodec.java | Removes legacy local/session storage command aliases and script generation. |
| java/src/org/openqa/selenium/remote/codec/AbstractHttpCommandCodec.java | Removes non-W3C /location command wiring. |
| java/src/org/openqa/selenium/remote/DriverCommand.java | Removes deprecated driver commands for location and storage APIs. |
| common/src/web/html5Page.html | Strips HTML5 feature test content from the fixture page. |
| common/src/web/html5/test.appcache | Deletes AppCache manifest fixture. |
| common/src/web/html5/status.html | Deletes AppCache-related status page fixture. |
| common/src/web/html5/geolocation.js | Deletes geolocation demo fixture script. |
| common/src/web/html5/database.js | Deletes WebSQL demo fixture script. |
| common/src/web/html5/yellow.jpg | Removes AppCache demo asset. |
| common/src/web/html5/red.jpg | Removes AppCache demo asset. |
| common/src/web/html5/green.jpg | Removes AppCache demo asset. |
| common/src/web/html5/blue.jpg | Removes AppCache demo asset. |
Comments suppressed due to low confidence (1)
java/test/org/openqa/selenium/environment/webserver/AppServerTestBase.java:122
- After deleting
manifestHasCorrectMimeType, this file appears to have leftover unused imports (StreamSupport.stream,Contents.string,HttpClient/HttpRequest/HttpResponse, etc.) and an unusedAPPCACHE_MIME_TYPEconstant. Unused imports will fail compilation—please remove the now-unused imports and constant (or otherwise use them).
@Test
void uploadsFile() throws Throwable {
String FILE_CONTENTS = "Uploaded file";
File testFile = File.createTempFile("webdriver", "tmp");
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy “HTML5” atoms (AppCache, WebSQL, geolocation, local/session storage) and their associated command wiring/fixtures so the JS atoms surface aligns with what modern browsers and the W3C WebDriver spec actually support (and to simplify the TypeScript migration).
Changes:
- Delete obsolete JS atoms + injected atoms for appcache/WebSQL/storage/geolocation and remove related Bazel build targets/fragments.
- Remove associated test pages/fixtures and Chrome-driver atom bundle entries.
- Remove legacy Java remote command definitions/codec handling for local/session storage and location, plus appcache-related server test coverage and web fixtures.
Reviewed changes
Copilot reviewed 41 out of 46 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| javascript/webdriver/test/atoms/storage/session_storage_test.html | Removes sessionStorage atom test page. |
| javascript/webdriver/test/atoms/storage/local_storage_test.html | Removes localStorage atom test page. |
| javascript/webdriver/test/atoms/inject/sql_database_test.html | Removes WebSQL injected atom test page. |
| javascript/webdriver/command.js | Drops obsolete command names for removed HTML5 features. |
| javascript/webdriver/atoms/storage/session_storage.js | Removes sessionStorage atom implementation. |
| javascript/webdriver/atoms/storage/local_storage.js | Removes localStorage atom implementation. |
| javascript/webdriver/atoms/storage/appcache.js | Removes appcache atom implementation. |
| javascript/webdriver/atoms/inject/sql_database.js | Removes injected WebSQL atom implementation. |
| javascript/webdriver/atoms/inject/session_storage.js | Removes injected sessionStorage atom implementation. |
| javascript/webdriver/atoms/inject/local_storage.js | Removes injected localStorage atom implementation. |
| javascript/webdriver/atoms/inject/appcache.js | Removes injected appcache atom implementation. |
| javascript/webdriver/atoms/inject/BUILD.bazel | Removes build targets/fragments for deleted injected atoms. |
| javascript/webdriver/atoms/BUILD.bazel | Stops globbing deleted storage atoms and removes related fragments. |
| javascript/selenium-webdriver/lib/test/fileserver.js | Removes routing entry for deleted offline appcache fixture page. |
| javascript/chrome-driver/BUILD.bazel | Removes deleted atoms from Chrome-driver atom bundle list. |
| javascript/atoms/test/html5/testdata/with_fallback.appcache | Removes appcache test manifest fixture. |
| javascript/atoms/test/html5/testdata/offline.html | Removes offline fallback test page fixture. |
| javascript/atoms/test/html5/testdata/frame_b.html | Removes nested-frame storage fixture page. |
| javascript/atoms/test/html5/testdata/frame_a.html | Removes nested-frame storage fixture page. |
| javascript/atoms/test/html5/storage_test.html | Removes HTML5 storage QUnit tests. |
| javascript/atoms/test/html5/no_manifest_appcache_test.html | Removes appcache test without manifest. |
| javascript/atoms/test/html5/nested_window_storage_test.html | Removes nested window storage tests. |
| javascript/atoms/test/html5/location_test.html | Removes geolocation tests. |
| javascript/atoms/test/html5/database_test.html | Removes WebSQL database tests. |
| javascript/atoms/test/html5/appcache_test.html | Removes appcache tests. |
| javascript/atoms/html5/storage.js | Removes bot.storage (HTML5 storage wrapper). |
| javascript/atoms/html5/location.js | Removes bot.geolocation atom. |
| javascript/atoms/html5/html5_browser.js | Removes bot.html5 feature detection. |
| javascript/atoms/html5/database.js | Removes bot.storage.database (WebSQL wrapper). |
| javascript/atoms/html5/appcache.js | Removes bot.appcache atom. |
| javascript/atoms/fragments/BUILD.bazel | Removes fragments for execute-sql and get-location. |
| javascript/atoms/BUILD.bazel | Removes :html5 library target and deps. |
| java/test/org/openqa/selenium/environment/webserver/AppServerTestBase.java | Removes appcache manifest MIME-type test. |
| java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpCommandCodec.java | Removes legacy local/session storage command aliases and script generation. |
| java/src/org/openqa/selenium/remote/codec/AbstractHttpCommandCodec.java | Removes non-W3C location commands. |
| java/src/org/openqa/selenium/remote/DriverCommand.java | Removes legacy location + deprecated storage command constants. |
| common/src/web/html5Page.html | Strips HTML5 demo content/manifest from the shared fixture page. |
| common/src/web/html5/test.appcache | Removes appcache manifest fixture. |
| common/src/web/html5/status.html | Removes appcache status fixture. |
| common/src/web/html5/geolocation.js | Removes geolocation demo script fixture. |
| common/src/web/html5/database.js | Removes WebSQL demo script fixture. |
java/test/org/openqa/selenium/environment/webserver/AppServerTestBase.java
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy “HTML5-era” WebDriver atoms/commands and associated test fixtures (WebSQL/AppCache and related storage/location support) to reduce dead/obsolete surface area ahead of an atoms-to-TypeScript migration.
Changes:
- Deleted WebDriver atoms and inject fragments for appcache, Web SQL database, and web storage (local/session) plus associated QUnit test pages.
- Removed corresponding command names/fragments/wiring from Bazel build targets and Chrome Driver atom bundles.
- Simplified/removes HTML5 demo/offline fixtures and Java codec/command constants related to these legacy endpoints.
Reviewed changes
Copilot reviewed 41 out of 46 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| javascript/webdriver/test/atoms/storage/session_storage_test.html | Removed session storage atom test page. |
| javascript/webdriver/test/atoms/storage/local_storage_test.html | Removed local storage atom test page. |
| javascript/webdriver/test/atoms/inject/sql_database_test.html | Removed WebSQL inject atom test page. |
| javascript/webdriver/command.js | Removed legacy command name constants (SQL/appcache/storage/location context). |
| javascript/webdriver/atoms/storage/session_storage.js | Deleted session storage atom wrapper. |
| javascript/webdriver/atoms/storage/local_storage.js | Deleted local storage atom wrapper. |
| javascript/webdriver/atoms/storage/appcache.js | Deleted appcache atom wrapper. |
| javascript/webdriver/atoms/inject/sql_database.js | Deleted WebSQL inject atom implementation. |
| javascript/webdriver/atoms/inject/session_storage.js | Deleted session storage inject atom implementation. |
| javascript/webdriver/atoms/inject/local_storage.js | Deleted local storage inject atom implementation. |
| javascript/webdriver/atoms/inject/appcache.js | Deleted appcache inject atom implementation. |
| javascript/webdriver/atoms/inject/BUILD.bazel | Removed build targets/fragments for deleted inject atoms. |
| javascript/webdriver/atoms/BUILD.bazel | Stopped globbing storage atoms; removed html5 deps/fragments. |
| javascript/selenium-webdriver/lib/test/fileserver.js | Removed html5 offline page mapping. |
| javascript/chrome-driver/BUILD.bazel | Removed legacy atom fragments from ChromeDriver bundle. |
| javascript/atoms/test/html5/testdata/with_fallback.appcache | Removed appcache manifest testdata. |
| javascript/atoms/test/html5/testdata/offline.html | Removed offline fallback test page. |
| javascript/atoms/test/html5/testdata/frame_b.html | Removed storage-related iframe testdata. |
| javascript/atoms/test/html5/testdata/frame_a.html | Removed storage-related iframe testdata. |
| javascript/atoms/test/html5/storage_test.html | Removed html5 storage tests. |
| javascript/atoms/test/html5/no_manifest_appcache_test.html | Removed appcache test page. |
| javascript/atoms/test/html5/nested_window_storage_test.html | Removed nested-frame storage tests. |
| javascript/atoms/test/html5/location_test.html | Removed geolocation tests. |
| javascript/atoms/test/html5/database_test.html | Removed WebSQL database tests. |
| javascript/atoms/test/html5/appcache_test.html | Removed appcache tests. |
| javascript/atoms/html5/storage.js | Deleted bot.storage HTML5 storage implementation. |
| javascript/atoms/html5/location.js | Deleted bot.geolocation implementation. |
| javascript/atoms/html5/html5_browser.js | Deleted bot.html5 feature detection helper. |
| javascript/atoms/html5/database.js | Deleted bot.storage.database WebSQL helpers. |
| javascript/atoms/html5/appcache.js | Deleted bot.appcache helpers. |
| javascript/atoms/fragments/BUILD.bazel | Removed legacy fragments (execute-sql, get-location). |
| javascript/atoms/BUILD.bazel | Removed html5 library target and deps. |
| java/test/org/openqa/selenium/environment/webserver/AppServerTestBase.java | Removed appcache MIME-type test coverage. |
| java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpCommandCodec.java | Removed script-alias wiring for legacy storage endpoints. |
| java/src/org/openqa/selenium/remote/codec/AbstractHttpCommandCodec.java | Removed non-W3C location endpoints wiring. |
| java/src/org/openqa/selenium/remote/DriverCommand.java | Removed legacy command constants (location + storage). |
| common/src/web/html5Page.html | Removed embedded HTML5 demo content/manifest usage. |
| common/src/web/html5/test.appcache | Removed appcache manifest fixture. |
| common/src/web/html5/status.html | Removed appcache status fixture. |
| common/src/web/html5/geolocation.js | Removed geolocation demo script. |
| common/src/web/html5/database.js | Removed WebSQL demo script. |
| javascript/atoms/test/html5/testdata/ps_logo2.png | Removed/updated html5 test asset. |
| common/src/web/html5/yellow.jpg | Removed/updated html5 test asset. |
| common/src/web/html5/red.jpg | Removed/updated html5 test asset. |
| common/src/web/html5/green.jpg | Removed/updated html5 test asset. |
| common/src/web/html5/blue.jpg | Removed/updated html5 test asset. |
java/test/org/openqa/selenium/environment/webserver/AppServerTestBase.java
Show resolved
Hide resolved
Comment on lines
107
to
110
| String PRINT_PAGE = "printPage"; | ||
| String IMPLICITLY_WAIT = "implicitlyWait"; | ||
| String SET_SCRIPT_TIMEOUT = "setScriptTimeout"; | ||
| String GET_LOCATION = "getLocation"; | ||
| String SET_LOCATION = "setLocation"; | ||
|
|
||
| /** | ||
| * @deprecated localStorage is not part of W3C WebDriver spec. Use ((JavascriptExecutor) | ||
| * driver).executeScript("return window.localStorage.getItem('key')") instead. | ||
| */ | ||
| @Deprecated String GET_LOCAL_STORAGE_ITEM = "getLocalStorageItem"; | ||
|
|
||
| /** | ||
| * @deprecated localStorage is not part of W3C WebDriver spec. Use ((JavascriptExecutor) | ||
| * driver).executeScript("return Object.keys(window.localStorage)") instead. | ||
| */ | ||
| @Deprecated String GET_LOCAL_STORAGE_KEYS = "getLocalStorageKeys"; | ||
|
|
||
| /** | ||
| * @deprecated localStorage is not part of W3C WebDriver spec. Use ((JavascriptExecutor) | ||
| * driver).executeScript("window.localStorage.setItem('key', 'value')") instead. | ||
| */ | ||
| @Deprecated String SET_LOCAL_STORAGE_ITEM = "setLocalStorageItem"; | ||
|
|
||
| /** | ||
| * @deprecated localStorage is not part of W3C WebDriver spec. Use ((JavascriptExecutor) | ||
| * driver).executeScript("window.localStorage.removeItem('key')") instead. | ||
| */ | ||
| @Deprecated String REMOVE_LOCAL_STORAGE_ITEM = "removeLocalStorageItem"; | ||
|
|
||
| /** | ||
| * @deprecated localStorage is not part of W3C WebDriver spec. Use ((JavascriptExecutor) | ||
| * driver).executeScript("window.localStorage.clear()") instead. | ||
| */ | ||
| @Deprecated String CLEAR_LOCAL_STORAGE = "clearLocalStorage"; | ||
|
|
||
| /** | ||
| * @deprecated localStorage is not part of W3C WebDriver spec. Use ((JavascriptExecutor) | ||
| * driver).executeScript("return window.localStorage.length") instead. | ||
| */ | ||
| @Deprecated String GET_LOCAL_STORAGE_SIZE = "getLocalStorageSize"; | ||
|
|
||
| /** | ||
| * @deprecated sessionStorage is not part of W3C WebDriver spec. Use ((JavascriptExecutor) | ||
| * driver).executeScript("return window.sessionStorage.getItem('key')") instead. | ||
| */ | ||
| @Deprecated String GET_SESSION_STORAGE_ITEM = "getSessionStorageItem"; | ||
|
|
||
| /** | ||
| * @deprecated sessionStorage is not part of W3C WebDriver spec. Use ((JavascriptExecutor) | ||
| * driver).executeScript("return Object.keys(window.sessionStorage)") instead. | ||
| */ | ||
| @Deprecated String GET_SESSION_STORAGE_KEYS = "getSessionStorageKey"; | ||
|
|
||
| /** | ||
| * @deprecated sessionStorage is not part of W3C WebDriver spec. Use ((JavascriptExecutor) | ||
| * driver).executeScript("window.sessionStorage.setItem('key', 'value')") instead. | ||
| */ | ||
| @Deprecated String SET_SESSION_STORAGE_ITEM = "setSessionStorageItem"; | ||
|
|
||
| /** | ||
| * @deprecated sessionStorage is not part of W3C WebDriver spec. Use ((JavascriptExecutor) | ||
| * driver).executeScript("window.sessionStorage.removeItem('key')") instead. | ||
| */ | ||
| @Deprecated String REMOVE_SESSION_STORAGE_ITEM = "removeSessionStorageItem"; | ||
|
|
||
| /** | ||
| * @deprecated sessionStorage is not part of W3C WebDriver spec. Use ((JavascriptExecutor) | ||
| * driver).executeScript("window.sessionStorage.clear()") instead. | ||
| */ | ||
| @Deprecated String CLEAR_SESSION_STORAGE = "clearSessionStorage"; | ||
|
|
||
| /** | ||
| * @deprecated sessionStorage is not part of W3C WebDriver spec. Use ((JavascriptExecutor) | ||
| * driver).executeScript("return window.sessionStorage.length") instead. | ||
| */ | ||
| @Deprecated String GET_SESSION_STORAGE_SIZE = "getSessionStorageSize"; | ||
|
|
Comment on lines
172
to
178
| ACCEPT_ALERT: 'acceptAlert', | ||
| DISMISS_ALERT: 'dismissAlert', | ||
| GET_ALERT_TEXT: 'getAlertText', | ||
| SET_ALERT_TEXT: 'setAlertValue', | ||
|
|
||
| EXECUTE_SQL: 'executeSQL', | ||
| GET_LOCATION: 'getLocation', | ||
| SET_LOCATION: 'setLocation', | ||
| GET_APP_CACHE: 'getAppCache', | ||
| GET_APP_CACHE_STATUS: 'getStatus', | ||
| CLEAR_APP_CACHE: 'clearAppCache', | ||
| IS_BROWSER_ONLINE: 'isBrowserOnline', | ||
| SET_BROWSER_ONLINE: 'setBrowserOnline', | ||
|
|
||
| GET_LOCAL_STORAGE_ITEM: 'getLocalStorageItem', | ||
| GET_LOCAL_STORAGE_KEYS: 'getLocalStorageKeys', | ||
| SET_LOCAL_STORAGE_ITEM: 'setLocalStorageItem', | ||
| REMOVE_LOCAL_STORAGE_ITEM: 'removeLocalStorageItem', | ||
| CLEAR_LOCAL_STORAGE: 'clearLocalStorage', | ||
| GET_LOCAL_STORAGE_SIZE: 'getLocalStorageSize', | ||
|
|
||
| GET_SESSION_STORAGE_ITEM: 'getSessionStorageItem', | ||
| GET_SESSION_STORAGE_KEYS: 'getSessionStorageKey', | ||
| SET_SESSION_STORAGE_ITEM: 'setSessionStorageItem', | ||
| REMOVE_SESSION_STORAGE_ITEM: 'removeSessionStorageItem', | ||
| CLEAR_SESSION_STORAGE: 'clearSessionStorage', | ||
| GET_SESSION_STORAGE_SIZE: 'getSessionStorageSize', | ||
|
|
||
| SET_SCREEN_ORIENTATION: 'setScreenOrientation', | ||
| GET_SCREEN_ORIENTATION: 'getScreenOrientation', |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy “HTML5” atoms, related test fixtures, and deprecated/legacy WebDriver commands that are no longer supported/maintained, as part of the cleanup ahead of moving atoms to TypeScript.
Changes:
- Deletes HTML5-related JS atoms (appcache, WebSQL, geolocation, local/session storage wrappers) and their QUnit tests/testdata.
- Removes associated Bazel build targets/fragments and ChromeDriver atom wiring for the deleted atoms.
- Removes legacy/deprecated command constants and HTTP codec handling for location + local/session storage in Java and JS.
Reviewed changes
Copilot reviewed 41 out of 46 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| javascript/webdriver/test/atoms/storage/session_storage_test.html | Removes QUnit coverage for sessionStorage atom wrappers. |
| javascript/webdriver/test/atoms/storage/local_storage_test.html | Removes QUnit coverage for localStorage atom wrappers. |
| javascript/webdriver/test/atoms/inject/sql_database_test.html | Removes QUnit coverage for WebSQL inject atom. |
| javascript/webdriver/command.js | Drops legacy command names for removed HTML5-related features. |
| javascript/webdriver/atoms/storage/session_storage.js | Deletes sessionStorage atom wrapper implementation. |
| javascript/webdriver/atoms/storage/local_storage.js | Deletes localStorage atom wrapper implementation. |
| javascript/webdriver/atoms/storage/appcache.js | Deletes appcache atom wrapper implementation. |
| javascript/webdriver/atoms/inject/sql_database.js | Deletes injectable WebSQL atom implementation. |
| javascript/webdriver/atoms/inject/session_storage.js | Deletes injectable sessionStorage atom implementation. |
| javascript/webdriver/atoms/inject/local_storage.js | Deletes injectable localStorage atom implementation. |
| javascript/webdriver/atoms/inject/appcache.js | Deletes injectable appcache atom implementation. |
| javascript/webdriver/atoms/inject/BUILD.bazel | Removes build targets and fragments for deleted inject atoms. |
| javascript/webdriver/atoms/BUILD.bazel | Stops globbing removed storage subdir and removes related fragments. |
| javascript/selenium-webdriver/lib/test/fileserver.js | Removes html5OfflinePage route entry. |
| javascript/chrome-driver/BUILD.bazel | Removes references to deleted atom fragments (execute-sql, storage/appcache related). |
| javascript/atoms/test/html5/testdata/with_fallback.appcache | Removes appcache test manifest fixture. |
| javascript/atoms/test/html5/testdata/offline.html | Removes offline fallback HTML fixture. |
| javascript/atoms/test/html5/testdata/frame_b.html | Removes storage test frame fixture. |
| javascript/atoms/test/html5/testdata/frame_a.html | Removes storage test frame fixture. |
| javascript/atoms/test/html5/storage_test.html | Removes HTML5 storage QUnit test suite. |
| javascript/atoms/test/html5/no_manifest_appcache_test.html | Removes appcache test without manifest attribute. |
| javascript/atoms/test/html5/nested_window_storage_test.html | Removes nested-frame storage QUnit test suite. |
| javascript/atoms/test/html5/location_test.html | Removes geolocation QUnit test suite. |
| javascript/atoms/test/html5/database_test.html | Removes WebSQL QUnit test suite. |
| javascript/atoms/test/html5/appcache_test.html | Removes appcache QUnit test suite. |
| javascript/atoms/html5/storage.js | Deletes bot.storage + Storage wrapper implementation. |
| javascript/atoms/html5/location.js | Deletes bot.geolocation atom implementation. |
| javascript/atoms/html5/html5_browser.js | Deletes bot.html5 feature detection helper. |
| javascript/atoms/html5/database.js | Deletes bot.storage.database (WebSQL) atom implementation. |
| javascript/atoms/html5/appcache.js | Deletes bot.appcache atom implementation. |
| javascript/atoms/fragments/BUILD.bazel | Removes closure fragments for execute-sql and get-location (HTML5 geolocation). |
| javascript/atoms/BUILD.bazel | Removes the html5 library target and deps referencing it. |
| java/test/org/openqa/selenium/environment/webserver/AppServerTestBase.java | Removes appcache MIME type test tied to deleted appcache fixture. |
| java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpCommandCodec.java | Removes legacy storage command aliases and script generation. |
| java/src/org/openqa/selenium/remote/codec/AbstractHttpCommandCodec.java | Removes non-W3C /location endpoints used by legacy location context. |
| java/src/org/openqa/selenium/remote/DriverCommand.java | Removes deprecated driver command constants for storage and location. |
| common/src/web/html5Page.html | Strips HTML5 demo content + manifest attribute from shared test page. |
| common/src/web/html5/test.appcache | Removes appcache manifest fixture. |
| common/src/web/html5/status.html | Removes appcache fallback “status” fixture. |
| common/src/web/html5/geolocation.js | Removes geolocation demo script fixture. |
| common/src/web/html5/database.js | Removes WebSQL demo script fixture. |
Comment on lines
174
to
178
| GET_ALERT_TEXT: 'getAlertText', | ||
| SET_ALERT_TEXT: 'setAlertValue', | ||
|
|
||
| EXECUTE_SQL: 'executeSQL', | ||
| GET_LOCATION: 'getLocation', | ||
| SET_LOCATION: 'setLocation', | ||
| GET_APP_CACHE: 'getAppCache', | ||
| GET_APP_CACHE_STATUS: 'getStatus', | ||
| CLEAR_APP_CACHE: 'clearAppCache', | ||
| IS_BROWSER_ONLINE: 'isBrowserOnline', | ||
| SET_BROWSER_ONLINE: 'setBrowserOnline', | ||
|
|
||
| GET_LOCAL_STORAGE_ITEM: 'getLocalStorageItem', | ||
| GET_LOCAL_STORAGE_KEYS: 'getLocalStorageKeys', | ||
| SET_LOCAL_STORAGE_ITEM: 'setLocalStorageItem', | ||
| REMOVE_LOCAL_STORAGE_ITEM: 'removeLocalStorageItem', | ||
| CLEAR_LOCAL_STORAGE: 'clearLocalStorage', | ||
| GET_LOCAL_STORAGE_SIZE: 'getLocalStorageSize', | ||
|
|
||
| GET_SESSION_STORAGE_ITEM: 'getSessionStorageItem', | ||
| GET_SESSION_STORAGE_KEYS: 'getSessionStorageKey', | ||
| SET_SESSION_STORAGE_ITEM: 'setSessionStorageItem', | ||
| REMOVE_SESSION_STORAGE_ITEM: 'removeSessionStorageItem', | ||
| CLEAR_SESSION_STORAGE: 'clearSessionStorage', | ||
| GET_SESSION_STORAGE_SIZE: 'getSessionStorageSize', | ||
|
|
||
| SET_SCREEN_ORIENTATION: 'setScreenOrientation', | ||
| GET_SCREEN_ORIENTATION: 'getScreenOrientation', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deletes code that have been removed from the web platform. These dont work anywhere so removing them as part of the plan to move the atoms to typescript
🔗 Related Issues
💥 What does this PR do?
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes