FLAC: Simplify tag writes#617
Merged
Serial-ATA merged 1 commit intomainfrom Feb 21, 2026
Merged
Conversation
PandorasFox
added a commit
to PandorasFox/music-magic
that referenced
this pull request
Feb 16, 2026
…EKTABLE bug lofty 0.23.x reorders metadata blocks when writing, pushing SEEKTABLE after PICTURE blocks. With preferred_padding(0), no PADDING block exists to carry the is_last flag, orphaning the SEEKTABLE past the last-flagged block and corrupting the file (ffprobe: "invalid sync code"). Default WriteOptions includes a trailing PADDING block that absorbs the is_last flag, keeping the SEEKTABLE inside the metadata region. The padding sizing issues that motivated preferred_padding(0) were fixed in lofty 0.23.2. Upstream fix: Serial-ATA/lofty-rs#617 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.