Skip to content

Issue 1903/fix naming combine#1977

Merged
ravichandra1998g merged 5 commits intoServiceNowDevProgram:mainfrom
WillemZeiler:issue-1903/fix-naming-combine
Oct 9, 2025
Merged

Issue 1903/fix naming combine#1977
ravichandra1998g merged 5 commits intoServiceNowDevProgram:mainfrom
WillemZeiler:issue-1903/fix-naming-combine

Conversation

@WillemZeiler
Copy link
Contributor

PR Description:

Intended to fix Issue 1903:
"The file names are wrong here, In this folder, Which we need to update and fix."

In this Pull Request the following is changed:

  • Delete Readme_Soumyadeep.md <- there were 2 readme's, removed 1.
  • Update Readme.md <- the one readme left I have updated to contain a description from both scripts in the folder.
  • Updated the 2 js names to clearly define the script, the new names are referenced in the readme.
    Note: No changes to the scripts as these were already existing.

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality < CODE NOT ADJUSTED

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

Updated the readme to combine the readme for both JS files. There are now 2 readme's which is confusing and reported in issue ServiceNowDevProgram#1903
…oumyadeep.md

Removed additional readme, as the naming is not in line, and another readme already exists. Updated the other readme to include the content of this one + improvements.
Rename the script to account for the second JS file in this folder. This is the name also referred to in the readme
Renamed the file to account for a second js in this folder. This file name is also referenced in the updated readme.
@ravichandra1998g ravichandra1998g self-assigned this Oct 9, 2025
Copy link
Contributor

@ravichandra1998g ravichandra1998g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@ravichandra1998g ravichandra1998g merged commit 7494a5c into ServiceNowDevProgram:main Oct 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants