Conversation
Popaulol
reviewed
Mar 17, 2024
|
|
||
| cur_file_var = ContextVar("cur_file_var",default=None) | ||
|
|
||
| class Pos: |
There was a problem hiding this comment.
Maybe use @dataclasses.dataclass from the standard library here (https://docs.python.org/3/library/dataclasses.html)
CoolCat467
suggested changes
Apr 20, 2024
| print(e) | ||
| raise CompileError(f'Unable to compile {self.block_name} at line {self.line}') | ||
| except e: | ||
| print(traceback.format_exc()) |
There was a problem hiding this comment.
Why are we getting rid of printing tracebacks? Having tracebacks are invaluable for debugging.
Author
There was a problem hiding this comment.
Correct, sorry , I was thinking about the end user experience however , which suffers from them.
| self.log(str(e) + '\a') | ||
| except CompileError as e: | ||
| self.log(str(e) + '\a') | ||
| pretty_print_error(e) |
There was a problem hiding this comment.
pretty_pint_error is not adding terminal bell character \a to end like existing system
|
|
||
| time.sleep(1) | ||
| except KeyboardInterrupt: | ||
| print("Goodbye!") |
There was a problem hiding this comment.
Maybe something like Exiting from keyboard interrupt instead?
Author
|
sorry I'm not addressing the requested changes but I'm depressed and kinda in a dump rn :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dirattributes can now be relative to a user configured instance folder, instead of being absolutepathlib.Pathinstead of stringssorry for not making an issue about this first but I just was in the mood to code :P