Conversation
All ProjectDiscovery images (subfinder, dnsx, naabu, amass, notify) are distroless and have no /bin/sh. Using `entrypoint: 'sh'` caused exit code 127. This commit: - Removes shell entrypoint from all 5 components, using image default entrypoint directly with CLI args passed via command array - Rewrites naabu and notify from complex shell scripts to TypeScript arg building with IsolatedContainerVolume for file I/O - Sets HOME=/tmp for all components (images run as nonroot, /root is not writable) - Updates naabu test assertions for new runner config - Documents the distroless image pattern in component-development.mdx Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
4d8c839 to
3c5e728
Compare
Switch all security and AI component Docker images from pinned version tags to :latest. Since these images are controlled by ShipSecAI on GHCR, using :latest ensures components always use our maintained builds (including distroless fixes) without requiring code changes per release. Components updated: subfinder, dnsx, naabu, httpx, notify, trufflehog, prowler, amass, opencode. Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
3c5e728 to
4e436ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/bin/sh, causing exit code 127 when usingentrypoint: 'sh'IsolatedContainerVolumefor file I/OHOME=/tmpfor all components (images run as nonroot,/rootis not writable — was causing permission denied errors)component-development.mdxChanges
worker/src/components/security/subfinder.tsentrypoint: 'sh', empty command,HOME=/tmpworker/src/components/security/dnsx.tsworker/src/components/security/amass.tsworker/src/components/security/naabu.tsworker/src/components/security/notify.tsworker/src/components/security/__tests__/naabu.test.tsdocs/development/component-development.mdxTest plan