refactor(dev): derive Vite proxy target from SHIPSEC_INSTANCE#285
Merged
refactor(dev): derive Vite proxy target from SHIPSEC_INSTANCE#285
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
LuD1161
force-pushed
the
LuD1161/use-shipsec-instance-for-vite-proxy
branch
2 times, most recently
from
ccfdac7 to
08a9366
Compare
Compute both the frontend port and backend proxy target directly from SHIPSEC_INSTANCE in vite.config.ts, removing VITE_API_URL and the --port/--strictPort CLI args from pm2.config.cjs. SHIPSEC_INSTANCE is the single source of truth for instance identity. Signed-off-by: Aseem Shrey <LuD1161@users.noreply.github.com>
LuD1161
force-pushed
the
LuD1161/use-shipsec-instance-for-vite-proxy
branch
from
08a9366 to
a693a1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VITE_API_URLenv var with direct computation fromSHIPSEC_INSTANCEinvite.config.tsVITE_API_URLfrom the PM2 frontend env block, passesSHIPSEC_INSTANCEinsteadSHIPSEC_INSTANCEis already the single source of truth for instance identity — no need for an intermediary env varVerification
just dev→ instance 0, Vite proxy targetslocalhost:3211SHIPSEC_INSTANCE=1 just dev→ instance 1, Vite proxy targetslocalhost:3311/apidirectly to backend, bypassing Vite proxy)