Remove packageManager, nodeDependencies, usesWorkspaces from App

[ryancbahan]

WHY are these changes introduced?

Depends on #7023. The App object currently acts as a god object, carrying environment concerns like packageManager, nodeDependencies, and usesWorkspaces alongside configuration data. With the Project model now owning these fields, services should receive them as explicit dependencies rather than reaching into App.

WHAT is this pull request doing?

Removes packageManager, nodeDependencies, usesWorkspaces fields and the updateDependencies() method from AppInterface and App class. Services now receive a Project instance explicitly:

• AppInterface / App — removed the three fields and updateDependencies()
• Options types — added project: Project to BuildOptions, DevOptions, DeployOptions, GenerateOptions, GenerateExtensionTemplateOptions
• localAppContext — now returns {app, project} so commands can destructure and pass project through
• installAppDependencies — takes Project instead of AppInterface
• info — takes project param; backward compat in --json output preserved by injecting project fields into serialized output
• loadOpaqueApp — surfaces packageManager for the link flow
• Test infra — added testProject() helper, updated all affected tests

How to test your changes?

1. pnpm type-check --projects=app passes
2. npx vitest run packages/app/ passes
3. Verify shopify app info --json still includes packageManager, nodeDependencies, usesWorkspaces in output

Measuring impact

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[ryancbahan]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Remove packageManager, nodeDependencies, usesWorkspaces from App #7035 👈 (View in Graphite)
• Integrate Project model into loader and decompose into composable stages #7023
• Add Project domain model for filesystem abstraction #7022
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/themes/api.d.ts

@@ -5,7 +5,6 @@ export type ThemeParams = Partial<Pick<Theme, 'name' | 'role' | 'processing' | '
 export type AssetParams = Pick<ThemeAsset, 'key'> & Partial<Pick<ThemeAsset, 'value' | 'attachment'>>;
 export declare function fetchTheme(id: number, session: AdminSession): Promise<Theme | undefined>;
 export declare function fetchThemes(session: AdminSession): Promise<Theme[]>;
-export declare function findDevelopmentThemeByName(name: string, session: AdminSession): Promise<Theme | undefined>;
 export declare function themeCreate(params: ThemeParams, session: AdminSession): Promise<Theme | undefined>;
 export declare function fetchThemeAssets(id: number, filenames: Key[], session: AdminSession): Promise<ThemeAsset[]>;
 export declare function deleteThemeAssets(id: number, filenames: Key[], session: AdminSession): Promise<Result[]>;

packages/cli-kit/dist/public/node/themes/theme-manager.d.ts

@@ -8,8 +8,8 @@ export declare abstract class ThemeManager {
     protected abstract removeTheme(): void;
     protected abstract context: string;
     constructor(adminSession: AdminSession);
-    findOrCreate(name?: string, role?: Role): Promise<Theme>;
-    fetch(name?: string, role?: Role): Promise<Theme | undefined>;
+    findOrCreate(): Promise<Theme>;
+    fetch(): Promise<Theme | undefined>;
     generateThemeName(context: string): string;
     create(themeRole?: Role, themeName?: string): Promise<Theme>;
 }
\ No newline at end of file

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟢	Statements	82.21%	14881/18102
🟡	Branches	74.53%	7358/9872
🟢	Functions	81.37%	3765/4627
🟢	Lines	82.6%	14066/17030

Test suite run success

3896 tests passing in 1500 suites.

Report generated by 🧪jest coverage report action from d20e281

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.