Fix pickup avail. component CSS animation#3884
Closed
AbiT-246 wants to merge 1 commit intoShopify:mainfrom
Closed
Conversation
|
This pull request has been marked as stale due to inactivity for 60 days. If no further activity occurs, it will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary:
Fixes #3785
Fixed invalid CSS syntax in the pickup availability component by removing incorrectly nested media queries from the keyframe animation definition. This resolves CSS linting errors and ensures the drawer animation works correctly across all screen sizes.
Why are these changes introduced?
Fixes CSS syntax errors in
component-pickup-availability.css. The@keyframes animateDrawerOpenrule contained invalid nested@mediaqueries, which is not allowed in CSS. This caused 12 linting errors and could potentially cause the animation to fail in some browsers.What approach did you take?
Removed the invalid nested
@mediaqueries from inside the@keyframesdefinition. The animation steps (0% and 100%) remain the same, and the media-specific behavior is already correctly handled outside the keyframes rule at lines 67-78, where the animation is conditionally applied on screens 750px and wider.Other considerations
Decision log
Visual impact on existing themes
No visual changes. This is a syntax fix only - the animation behavior and appearance remain identical. The pickup availability drawer will continue to slide in from the right on desktop screens (≥750px) as before.
Testing steps/scenarios
Checklist
Added PR summary for release notes
Requested review from UX (Only for changes that are affecting the experience or perceivable visual details)
Created a ticket for the help.shopify.com documentation team about updates to theme settings. (Internal-only task)
Followed theme code principles
Linted with Theme Check
Tested on mobile
Tested on multiple browsers
Tested for accessibility