Merged
Conversation
6658614 to
cc411d2
Compare
adampetro
reviewed
Apr 16, 2025
Contributor
adampetro
left a comment
There was a problem hiding this comment.
I wonder if it would make sense to create a Codec enum like:
enum Codec {
Json,
Msgpack,
}and then select a codec based on conditions, then put all of the conditional codec logic into methods on Codec, such as:
impl Codec {
fn transcode_from_json_bytes(&self, bytes: Vec<u8>) -> `anyhow::Result<Vec<u8>>` {
match self {
Self::Json => Ok(bytes),
Self::Msgpack => {
todo!()
}
}
}
}3e3ef79 to
b0786c0
Compare
adampetro
reviewed
Apr 17, 2025
97e9e7c to
f728a5f
Compare
Contributor
5de7479 to
a804934
Compare
3258dcb to
7bd4fd0
Compare
Contributor
saulecabrera
left a comment
There was a problem hiding this comment.
Looking good, I think after the last two comments are resolved we can land this.
saulecabrera
approved these changes
Apr 29, 2025
Contributor
saulecabrera
left a comment
There was a problem hiding this comment.
Thanks for iterating on this. Approving from my end, I'll leave the final approval to @andrewhassan, given the latest comments.
adampetro
reviewed
May 1, 2025
adampetro
reviewed
May 1, 2025
adampetro
reviewed
May 1, 2025
adampetro
approved these changes
May 1, 2025
Contributor
adampetro
left a comment
There was a problem hiding this comment.
Let's squash the commits before merging
Contributor
|
And hold off on merging for the finalized initial version of the provider module |
e9b12e9 to
469de76
Compare
9bddef5 to
0a99983
Compare
andrewhassan
reviewed
May 6, 2025
a33ddba to
d331604
Compare
adampetro
requested changes
May 7, 2025
adampetro
reviewed
May 7, 2025
adampetro
approved these changes
May 7, 2025
9a31447 to
b0447d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasm API Support for function-runner
Closes: https://github.com/shop/issues-shopifyvm/issues/32
Function-runner now detects when a module is using the Wasm API by checking if it imports modules with names starting with
shopify_function_v.When a Wasm API function is detected:
For output handling:
🎩 Tophat
WASM API
JAVY_V2
Testing
echo.trampolined.wasmfunctionnote: todo - test everything else is still working as expected