This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Conversation
rennyG
approved these changes
Jan 25, 2023
frehner
reviewed
Jan 25, 2023
frehner
reviewed
Jan 25, 2023
packages/react/src/seo.ts
Outdated
| import {Maybe} from './storefront-api-types.js'; | ||
| import {WithContext} from 'schema-dts'; | ||
|
|
||
| export interface BaseSeo { |
Contributor
There was a problem hiding this comment.
I'm going to look into having these types actually match what they should be, and remove the any.
Contributor
Author
There was a problem hiding this comment.
Okay, I've made all the other changes, but won't merge until you approve 🙇 Happy to work together on this tomorrow or later this week too.
Contributor
There was a problem hiding this comment.
A start. It's not done, but it should be a bit better already. Want to take it over from here? (note that that PR merged into this PR, not into the main branch)
jplhomer
approved these changes
Jan 25, 2023
cartogram
force-pushed
the
seo
branch
4 times, most recently
from
8e17745 to
c47a794
Compare
Co-authored-by: Josh Larson <jplhomer@gmail.com>
kinda better? kinda more better? no more red fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the SEO library (mainly the
generateSeoTagsfunction) from the hydrogen repo to this repo.Additional context
I've also added docs and examples.
Related: Shopify/hydrogen#389, Shopify/hydrogen#380, Shopify/hydrogen#370, Shopify/hydrogen#389
Before submitting the PR, please make sure you do the following:
fixes #123)yarn changeset addif this PR cause a version bump based on Keep a Changelog. If you have a breaking change, it will need to wait until the next major version release. Otherwise, use patch updates even for new features. Read more about Storefront Kit's versioning.