Update tsconfig so that cmd+clicking takes you to source code, not d.ts file#3308
Closed
Update tsconfig so that cmd+clicking takes you to source code, not d.ts file#3308
cmd+clicking takes you to source code, not d.ts file#3308Conversation
…d.ts file Previously, if I was in a file like `templates/skeleton/app/root.tsx` and I cmd+clicked on the function 'getShopifyAnalytics` (to go to its definition), I was taken to a d.ts file and not the actual source code in the Hydrogen package. Now, I'm taken to the actual source code (ie: `packages/hydrogen/src/analytics-manager/AnalyticsProvider.tsx in this case).
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
Contributor
|
This pull request has been marked as stale due to inactivity for 60 days. If no further activity occurs, it will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Previously, if I was in a file like
templates/skeleton/app/root.tsxand I cmd+clicked on the function 'getShopifyAnalytics` (to go to its definition), I was taken to a d.ts file and not the actual source code in the Hydrogen package.Now, I'm taken to the actual source code (ie: `packages/hydrogen/src/analytics-manager/AnalyticsProvider.tsx in this case).
WHAT is this pull request doing?
Sets
declarationMap: truein this repo's tsconfig. Docs on declarationMap settingHOW to test your changes?
Before Fix (Reproduce the Issue):
npm install && npm run buildat the root(compiled declarations, no source code)
After Fix (Verify Solution):
packages/hydrogen/src/analytics-manager/AnalyticsProvider.tsx:440 (actual source
code)
Post-merge steps
N/A
Checklist