Open
Conversation
- Add resource_limits to VALID_SPEC_KEYS and LazySpec (attr_reader + param) - Pass raw_resource_limits through SpecLoader to LazySpec.new - Include resource_limits in render_options in cli/runner.rb - Apply limits via Liquid::ResourceLimits in the liquid_ruby.rb adapter - Add specs/basics/resource-limits.yml with three cumulative/per-template tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Situation
liquid-spec had no way to test resource limit enforcement through template rendering. Cumulative resource scoring (Liquid v5.12.0) needs behavioral specs that verify limits survive
reset()across partial renders — unit tests onResourceLimitsalone don't exercise the full render pipeline.Execution
Added
resource_limitsas a new spec field. Specs can now configurerender_score_limit,cumulative_render_score_limit, etc. The runner passes these throughrender_optionsto the adapter, which builds aLiquid::ResourceLimitsobject and injects it into the render context. Updatedliquid_ruby.rbexample adapter.Added 3 behavioral specs in
specs/basics/resource-limits.yml:cumulative_render_score_across_partials— cumulative limit triggers across multiple partial renderscumulative_limits_not_triggered_when_unset— no limits means no enforcementper_template_limit_still_works_with_cumulative— per-template limit fires even with generous cumulative limit