Conversation
ghost
added
the
|
@JoelBesada Couldn't sign the CLA. Rate limit exceeded. |
mblarsen
left a comment
mblarsen
left a comment
There was a problem hiding this comment.
I like the idea. It is a good way to use traditional styles like syntax.
However, I think this PR will never pass as long as you make the typography change at the same time. I strongly suggest that you split this into two PRs.
I'm not a contributor so you don't have to take my word for anything, just a friendly suggestion.
|
|
||
| ## 1.3.1 - 2020-10-26 | ||
| * Silently ignore any errors caused by missing a variant definition in the theme (e.g. textVariants), to preserve backwards compatibility. [#64](https://github.com/Shopify/restyle/pull/64) by [@jonogreenz](https://github.com/jonogreenz) | ||
| * Silently ignore any errors caused by missing a variant definition in the theme (e.g. typography), to preserve backwards compatibility. [#64](https://github.com/Shopify/restyle/pull/64) by [@jonogreenz](https://github.com/jonogreenz) |
There was a problem hiding this comment.
Perhaps leave old CHANGELOG entries untouched
| backgroundColor="mainBackground" | ||
| paddingVertical="xl" | ||
| paddingHorizontal="m"> | ||
| paddingHorizontal="m" | ||
| > | ||
| <Text variant="header">Welcome</Text> | ||
| <Box | ||
| flexDirection={{ |
There was a problem hiding this comment.
Generally avoid reformatting parts of code that you are not making any changes in.
It makes it really hard to spot the actual changes.
|
|
||
| const useStyles = makeStyle<YourTheme>(theme => ({ | ||
| container: { |
There was a problem hiding this comment.
| const useStyles = makeStyle<YourTheme>(theme => ({ | |
| container: { | |
| const useStyles = makeStyles<YourTheme>(theme => ({ | |
| container: { |
|
Apologies for the long delay, is this PR still relevant? |
I find it really useful, but don't know if @matinzd is still interested |
|
Hey, I am still interested in having this function and it makes components much cleaner. I will try to rebase the PR and make some changes to the function as it has some typescript issues. |
|
any updates in this feature? |
gvarandas
force-pushed
the
master
branch
9 times, most recently
from
334b3da to
f86990a
Compare
4 participants
Changes
textVariantstotypographyfor better coherence