feat: add borderCurve and pointerEvents style properties#228
feat: add borderCurve and pointerEvents style properties#228mlecoq wants to merge 3 commits intoShopify:masterfrom
Conversation
|
it needs this first facebook/react-native@a0800ff (types are now in react-native repo) |
| const {root} = render( | ||
| <ThemeProvider theme={theme}> | ||
| <Component opacity={0.5} pointerEvents="auto" /> | ||
| <Component opacity={0.5} removeClippedSubviews /> |
There was a problem hiding this comment.
Why was pointerEvents replaced by removeClippedSubviews?
There was a problem hiding this comment.
Because pointerEvents is now present in style since rn 0.71 so this test failed. I have used removeClippedSubview but I could choose another property (that is not a style one)
mattfrances
left a comment
mattfrances
left a comment
There was a problem hiding this comment.
React Native's borderCurve and pointerEvents don't seem to have been added to React Native's ViewStyle type. When clicking through ViewStyle on this line, borderCurve and pointerEvents are not included (see image below). This is causing the build failures. Do you know why they're not being included?
|
Yes, I added them in @types/react-native but now types are directly in react-native, a similar PR has been merged but related commits are not in react native 0.71.2. We have to wait a future version |
gvarandas
force-pushed
the
master
branch
9 times, most recently
from
334b3da to
f86990a
Compare
2 participants
Description
see comment #188 (comment)
Checklist