Add support for defining fonts in the theme#233
Open
ergenekonyigit wants to merge 2 commits intoShopify:masterfrom
Open
Add support for defining fonts in the theme#233ergenekonyigit wants to merge 2 commits intoShopify:masterfrom
ergenekonyigit wants to merge 2 commits intoShopify:masterfrom
Conversation
|
can this PR be merged ASAP ? Thanks |
Author
|
I've updated the conflicts. |
|
@ergenekonyigit any updates on this? |
Author
|
@dalmendray I'm waiting for a review or merge. |
|
@ergenekonyigit So I guess they didnt merged it? |
Author
|
@TarikOez unfortunately. Looks like this project is not maintained anymore. |
334b3da to
f86990a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr adds support for defining fonts in the theme. After this implementation, we can add custom fonts and use them in the theme.
Screenshots or videos (if needed)
Checklist