add back-reference for protected resource object to circuit breaker#930
Open
Aguasvivas22 wants to merge 165 commits intomainfrom
Open
add back-reference for protected resource object to circuit breaker#930Aguasvivas22 wants to merge 165 commits intomainfrom
Aguasvivas22 wants to merge 165 commits intomainfrom
Conversation
Update variable names Fill sliding window with 1 hr worth data Add comment Update experiemnt resource to be deterministic Change deterministic default value to false Cleanup Remove unused variable Make initial seed error rate more customizable Add seed_error_rate as a property
* Prefilling added * Change initial duration to 900 s
* testing different circuit breaking scenarios * adding concurrency * adds more puts to get further information during phases * Fixing concurrency, unprotected ping, extras * update classic sustained test * cleaning up outdated tests, and testing without ping rate * modify ki instead of dividing by window size --------- Co-authored-by: Abdulrahman Alhamali <abdulrahman.alhamali@shopify.com>
* add elastic defensiveness * remove kd * update docs and run experiments * fix tests --------- Co-authored-by: Fernando Aguasvivas <fernando.aguasvivas@shopify.com>
use symbols for active_breaker_type instead of strings create separate acquire methods for readability use active_breaker_type consistently to determine breaker type remove useless AI-generated tests fix useful tests
use_adaptive proc no longer exists at initialization (proc is set at runtime)
clean up unneeded tests and AI fluff
…andle_adaptive_acquire`
…://github.com/Shopify/semian into adriangudas/adaptive-semian-feature-flag-gate
…o that it can be used in notify method
Base automatically changed from
adriangudas/adaptive-semian-feature-flag-gate
to
pid-take-2
December 17, 2025 15:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add back-reference for protected resource object to circuit breaker so that it can be used in notify method