Merged
Conversation
Edouard-chin
force-pushed
the
get-rid-of-sassc-2
branch
from
2e3877b to
7825358
Compare
Edouard-chin
approved these changes
Mar 11, 2026
Member
Edouard-chin
left a comment
Edouard-chin
left a comment
There was a problem hiding this comment.
👍 The hardcoded color is fine if if the advantage is removing sassc.
@tdickers any concern on your side changing this ?
Contributor
Author
|
❤️ thanks @Edouard-chin. Would I be pushing it, if I requested a release? It's so I can update: https://github.com/ruby/ruby-bench/blob/e420a71a39fbb16ef87ef174295552bd0a991e2a/benchmarks/shipit/Gemfile#L13 |
Member
|
I released 0.45.0. Thanks ! |
k0kubun
added a commit
to k0kubun/shipit-engine
that referenced
this pull request
Mar 19, 2026
Same approach as Shopify#1467 for sassc-rails: compiled all CoffeeScript files to plain JavaScript using the CoffeeScript 1.12.7 compiler (matching coffee-rails 5.0), then removed the coffee-rails dependency entirely. This is needed because coffee-rails depends on coffee-script which depends on execjs, causing issues in ruby-bench (ruby/ruby-bench#493). - Compiled 18 .coffee files to .js using `coffee -bc` (bare compile) - Preserved sprockets directives (require, require_tree, require_self) - Preserved ERB in task/notifications.js.erb for image_path helpers - Removed coffee-rails from gemspec and lib/shipit.rb - No changes needed to HTML templates or asset precompile configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Shipit never followup the various asset pipeline changes, and is still using sprockets 3.x with
sassc, which is becoming a problem now, because Shipit is part of theruby-benchsuite andsasscis causing problem on ruby-head: ruby/ruby-bench#476 (ruby/ruby-bench@5893da2)Solution
I looked at using the newer SASS stack (sass dart etc) but it's very tricky as it means upgrading sprockets and a lot of other things, some SASS functions need to be reimplemented, and the compiler is throwing lots of deprecations.
Overall, vanilla CSS is now much more powerful that it once was when Shipit started, and the Shipit CSS hasn't changed much in years, I believe we might as well use vanilla CSS, and that makes migrating to something other than sprockets 3.x much easier in the future.
Implementation
I did compile the CSS with the existing compiler and then cleaned it up and re-introduced data-uri helpers using ERB, etc.
We do lose some things such as a few color functions that are now hardcoded colors, but here again I think it's not a huge deal. If one day someone feel like doing an overall of the CSS they might as well start from scratch anyways.
We may also want to consider doing something similar for
coffee-rails, but it's not a problem today.cc @Edouard-chin @etiennebarrie @rafaelfranca