Skip to content

Validate host param in HomeController to prevent open redirect #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amcaplan merged 1 commit into from
Mar 5, 2026
Merged

Validate host param in HomeController to prevent open redirect #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion web/app/controllers/home_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ class HomeController < ApplicationController

def index
if ShopifyAPI::Context.embedded? && (!params[:embedded].present? || params[:embedded] != "1")
redirect_to(ShopifyAPI::Auth.embedded_app_url(params[:host]), allow_other_host: true)
redirect_url = ShopifyAPI::Auth.embedded_app_url(params[:host])
redirect_url = ShopifyApp.configuration.root_url if deduced_phishing_attack?(redirect_url)
redirect_to(redirect_url, allow_other_host: true)
else
contents = File.read(File.join(Rails.env.production? ? PROD_INDEX_PATH : DEV_INDEX_PATH, "index.html"))
contents.sub!("%VITE_SHOPIFY_API_KEY%", ShopifyApp.configuration.api_key)
Expand Down