Add comment_command_flags and comment_package_manager params#41
Add comment_command_flags and comment_package_manager params#41gonzaloriestra wants to merge 7 commits intomainfrom
Conversation
005d247 to
7c357a3
Compare
7c357a3 to
8dacdbe
Compare
|
@gonzaloriestra can you follow the naming of inputs in this PR #32 |
6cd7c1b to
fb962c3
Compare
|
@alex-page updated, thanks! Should I just merge and use |
7a92743 to
e03ae1a
Compare
|
@gonzaloriestra I can do a release tomorrow. Just merge to |
|
@alex-page the main branch seems to be broken. I tried first with this branch and it didn't work, although it didn't show any error. Then I switched to main (after fixing this typo), and I got the same result: https://github.com/Shopify/cli/actions/runs/19293916160/job/55171040211 Could you please have a look? |
a01720c to
f536e4a
Compare
3ba8191 to
4c9288a
Compare
It seems like it is green in CI? Is there a failing run or is it just not publishing? |
|
@alex-page it's not failing, but not publishing. It just finishes and does nothing. |
72d73ea to
ee98df3
Compare
ee98df3 to
6446eb8
Compare
|
@alex-page there was another typo from main, but it's working now: Shopify/cli#6750 (comment) Can we merge it? |
I'm adding two optional params:
comment_command_flags: to append to the global install commandcomment_package_manager: to use for the global install command instead of the inferred oneWe want them to simplify the snapit message in the CLI: