Silence expected warning about __id__ definition#2469
Draft
amomchilov wants to merge 1 commit intomainfrom
Draft
Silence expected warning about __id__ definition#2469amomchilov wants to merge 1 commit intomainfrom
__id__ definition#2469amomchilov wants to merge 1 commit intomainfrom
Conversation
Morriar
reviewed
Jan 5, 2026
Comment on lines
99
to
116
| it "might return the wrong results without Reflection helpers" do | ||
| foo = LyingFoo.new | ||
|
|
||
| refute_equal([], LyingFoo.constants) | ||
| refute_equal("Tapioca::LyingFoo", LyingFoo.name) | ||
| refute_equal([Object, Kernel, BasicObject], LyingFoo.ancestors) | ||
| refute_equal(Object, LyingFoo.superclass) | ||
| assert_equal(String, LyingFoo.singleton_class) | ||
| assert_equal([:foo, :bar, :baz], LyingFoo.public_instance_methods) | ||
| assert_equal([:foo, :bar, :baz], LyingFoo.protected_instance_methods) | ||
| assert_equal([:foo, :bar, :baz], LyingFoo.private_instance_methods) | ||
| assert_equal(:lies, LyingFoo.method(:class)) | ||
|
|
||
| refute_equal(LyingFoo, foo.class) | ||
| assert_equal(1, foo.__id__) | ||
| refute(foo.equal?(foo)) | ||
| assert(foo.equal?(1)) | ||
| end |
Member
There was a problem hiding this comment.
I think the test is useful since it would error if someone removed the bind_call versions of the various look-ups.
| assert_instance_of(Method, method) | ||
|
|
||
| assert_equal(LyingFoo, Runtime::Reflection.class_of(foo)) | ||
| refute_equal(1, Runtime::Reflection.object_id_of(foo)) |
Contributor
There was a problem hiding this comment.
Could we not override __id__ and just test the id against the real one?
Suggested change
| refute_equal(foo.__id__, Runtime::Reflection.object_id_of(foo)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Removes this line noise from CI logs:
Implementation
Hooks in the
Warningcallback chain, raises and exception, and ignores it if it's the one we expected.