Add cross-platform yt-dlp resolution without breaking Windows builds#3
Closed
Add cross-platform yt-dlp resolution without breaking Windows builds#3
Conversation
…ux/macOS Safely refactors ensureManagedYtDlpPath() into platform-specific functions: - winManagedYtDlpPath(): exact same logic as original (Windows unchanged) - unixManagedYtDlpPath(): uses `which yt-dlp` for Linux/macOS - ensureManagedYtDlpPath(): dispatches based on process.platform Does NOT change extraResources.from (keeps "bin") to preserve Windows build. Adds cross-platform build prerequisites to README. Co-authored-by: Shripad735 <139649110+Shripad735@users.noreply.github.com>
…ions Co-authored-by: Shripad735 <139649110+Shripad735@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review cross functionality for Windows compatibility
Add cross-platform yt-dlp resolution without breaking Windows builds
Feb 24, 2026
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed PR #2 (cross-platform macOS/Linux support). The core refactoring is sound but contains a breaking change for Windows:
extraResources.fromwas changed from"bin"to"electron/bin", which mismatchesgetBundledBinaryPath()resolving to<project_root>/bin/— packaged Windows builds would fail to findyt-dlp.exe.This PR applies the cross-platform changes safely:
ensureManagedYtDlpPath()—winManagedYtDlpPath()preserves the original Windows logic verbatim;unixManagedYtDlpPath()useswhich yt-dlpfor Linux/macOSextraResources.fromchange — keeps"bin"to stay consistent withgetBundledBinaryPath()'s dev-mode path (path.join(__dirname, "..", "bin", binaryName))winManagedYtDplPath→winManagedYtDlpPathPR #2 review summary
main.jsrefactoringextraResources.from: "electron/bin"package-lock.jsonversion bump💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.