Proposed changes/additions extracted from how I patched this library for use with the Crystal OpenTelemetry project#6
Open
wyhaines wants to merge 3 commits intoSija:masterfrom
Open
Conversation
…sms to turn on debugging, so that the -DDEBUG flag, at compilation, also enables debugging. This allows one to build a binary that has debugging always enabled, regardless of ENV settings. In addition, it adds a `macro_debug!` macro that inserts _macro_ debugging code. Both of these are extracted from the Crystal OpenTelemetry project, where I have included them as a massive monkeypatch in order to use them for internal debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does a couple of things. It expands the allowable mechanisms to turn on debugging, so that the -DDEBUG flag, at compilation, also enables debugging. This allows one to build a binary that has debugging always enabled, regardless of ENV settings. It also establishes that any shell-truth value (not empty, not
0, and notfalse) is an enabling value for the environment variable. i.e.is logically the same as
In addition, it adds a
macro_debug!macro that inserts macro debugging code. For example:This will print a compile-time debugging message about the missing method, if debugging is enabled.
Both of these are extracted from the Crystal OpenTelemetry project, where I have included them as a substantial monkeypatch in order to use them for internal debugging.