CI: per-OS Tauri build, robust Windows artifact collection, add Windows icon#7
Merged
kiyarose merged 5 commits intocopilot/update-app-icon-and-cicd-workflowsfrom Mar 30, 2026
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Rust | Mar 30, 2026 12:34a.m. | Review ↗ |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CI workflows and Tauri configuration to produce correct per-OS bundles, improve Windows artifact collection reliability, and ensure Windows builds embed the proper icon.
Changes:
- Make Tauri build invocation OS-aware in GitHub Actions (Windows: nsis/msi, Ubuntu: appimage, macOS: app).
- Improve Windows artifact collection by recursively collecting installer outputs and falling back to portable executables when needed; upload a directory of artifacts.
- Add a Windows
.icoicon entry to Tauri bundle configuration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
cross-platform/src-tauri/tauri.conf.json |
Adds icons/icon.ico to Tauri bundle icon list for Windows packaging. |
.github/workflows/prerelease.yml |
Uses per-OS Tauri bundle builds and more robust Windows artifact collection/upload. |
.github/workflows/build-and-release.yml |
Mirrors prerelease workflow changes for per-OS bundling and robust Windows artifact collection/upload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…fix-windows-installer-not-found-error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
.icoentry in the Tauri config so Windows builds embed the proper icon.Description
npm run buildstep with an OS-awarecasethat runsnpm run tauri -- buildwith--bundles nsis,msion Windows,--bundles appimageon Ubuntu, and--bundles appon macOS.globstar, searching recursively undercross-platform/src-tauri/target/release/bundle, copying any*.msi/*.exematches intoPinStick-${APP_VERSION}-windows, and falling back to looking for portable*.exefiles in the release directory if no bundle installers are found.WINDOWS_ARTIFACT_DIRand upload that directory instead of a single installer file.icons/icon.icotocross-platform/src-tauri/tauri.conf.jsonso the Windows bundle includes an ICO icon.Testing
Codex Task