Skip to content

CI: per-OS Tauri build, robust Windows artifact collection, add Windows icon#7

Merged
kiyarose merged 5 commits intocopilot/update-app-icon-and-cicd-workflowsfrom
codex/fix-windows-installer-not-found-error
Mar 30, 2026
Merged

CI: per-OS Tauri build, robust Windows artifact collection, add Windows icon#7
kiyarose merged 5 commits intocopilot/update-app-icon-and-cicd-workflowsfrom
codex/fix-windows-installer-not-found-error

Conversation

@kiyarose
Copy link
Copy Markdown
Member

Motivation

  • Ensure the GitHub Actions build step invokes the correct Tauri bundle command per runner OS so produced artifacts match platform expectations.
  • Make Windows artifact collection more robust by searching nested bundle outputs and falling back to portable executables when installer bundles are not present.
  • Include a Windows .ico entry in the Tauri config so Windows builds embed the proper icon.

Description

  • Replaced the generic npm run build step with an OS-aware case that runs npm run tauri -- build with --bundles nsis,msi on Windows, --bundles appimage on Ubuntu, and --bundles app on macOS.
  • Improved Windows artifact collection by enabling globstar, searching recursively under cross-platform/src-tauri/target/release/bundle, copying any *.msi/*.exe matches into PinStick-${APP_VERSION}-windows, and falling back to looking for portable *.exe files in the release directory if no bundle installers are found.
  • Export a directory path via WINDOWS_ARTIFACT_DIR and upload that directory instead of a single installer file.
  • Added icons/icon.ico to cross-platform/src-tauri/tauri.conf.json so the Windows bundle includes an ICO icon.

Testing

  • No automated tests were executed as part of this change; the modifications are CI workflow and config updates that will be validated when the GitHub Actions matrix runs on the next push or PR.

Codex Task

Copilot AI review requested due to automatic review settings March 30, 2026 00:07
@deepsource-io
Copy link
Copy Markdown

deepsource-io bot commented Mar 30, 2026

DeepSource Code Review

We reviewed changes in d090ed1...e41b1b4 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Rust Mar 30, 2026 12:34a.m. Review ↗

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI workflows and Tauri configuration to produce correct per-OS bundles, improve Windows artifact collection reliability, and ensure Windows builds embed the proper icon.

Changes:

  • Make Tauri build invocation OS-aware in GitHub Actions (Windows: nsis/msi, Ubuntu: appimage, macOS: app).
  • Improve Windows artifact collection by recursively collecting installer outputs and falling back to portable executables when needed; upload a directory of artifacts.
  • Add a Windows .ico icon entry to Tauri bundle configuration.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
cross-platform/src-tauri/tauri.conf.json Adds icons/icon.ico to Tauri bundle icon list for Windows packaging.
.github/workflows/prerelease.yml Uses per-OS Tauri bundle builds and more robust Windows artifact collection/upload.
.github/workflows/build-and-release.yml Mirrors prerelease workflow changes for per-OS bundling and robust Windows artifact collection/upload.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kiyarose kiyarose merged commit a11d0ad into copilot/update-app-icon-and-cicd-workflows Mar 30, 2026
@kiyarose kiyarose deleted the codex/fix-windows-installer-not-found-error branch March 30, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants