Skip to content

WWSTCERT-9857 Add Zooz ZSE50 to zwave-siren (for WWST Cert)#2681

Merged
cbaumler merged 10 commits intoSmartThingsCommunity:mainfrom
jtp10181:zwave-siren_zse50
Apr 9, 2026
Merged

WWSTCERT-9857 Add Zooz ZSE50 to zwave-siren (for WWST Cert)#2681
cbaumler merged 10 commits intoSmartThingsCommunity:mainfrom
jtp10181:zwave-siren_zse50

Conversation

@jtp10181
Copy link
Copy Markdown
Contributor

@jtp10181 jtp10181 commented Jan 2, 2026 •
edited
Loading

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding Zooz ZSE50 for WWST Certification

Summary of Completed Tests

  • Tested all features manually
  • Passed full integration test from the developer test suite

greens
greens reviewed Jan 13, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/profiles/zooz-zse50.yml
greens
greens reviewed Jan 13, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/src/init.lua Outdated
greens
greens reviewed Jan 13, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Outdated
greens
greens reviewed Jan 13, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua
greens
greens reviewed Jan 13, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Outdated
greens
greens reviewed Jan 13, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua
greens
greens reviewed Jan 14, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Outdated
greens
greens reviewed Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@greens greens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write and include some unit tests and remove your debug logging.

@greens greens changed the title Add Zooz ZSE50 to zwave-siren (for WWST Cert) WWSTCERT-9857 Add Zooz ZSE50 to zwave-siren (for WWST Cert) Jan 14, 2026
@jtp10181
Copy link
Copy Markdown
Contributor Author

jtp10181 commented Jan 14, 2026

I will work on the remaining issues and follow up when complete.

@jtp10181
zwave-siren WWST fixes
310a022 
* Remove firmwareUpdate from driver_template
* Fix copyright date
* Remove unnecessary profile switch
pegor-karoglanian
pegor-karoglanian reviewed Feb 5, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Outdated
pegor-karoglanian
pegor-karoglanian reviewed Feb 5, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Outdated
pegor-karoglanian
pegor-karoglanian reviewed Feb 5, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Outdated
pegor-karoglanian
pegor-karoglanian reviewed Feb 5, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Outdated
wkhenon
wkhenon reviewed Feb 12, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua
Copy link
Copy Markdown
Contributor

@wkhenon wkhenon Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reiterating some of the comments that Pegor left, be sure to remove all usages of log.debug() from this file was your implementation is complete.

@KKlimczukS KKlimczukS requested a review from cbaumler March 19, 2026 13:04
@cbaumler
Copy link
Copy Markdown
Contributor

cbaumler commented Mar 20, 2026

Hi @jtp10181 let us know when you're ready for a re-review.

@jtp10181
Copy link
Copy Markdown
Contributor Author

jtp10181 commented Mar 21, 2026 •
edited
Loading

Hi @jtp10181 let us know when you're ready for a re-review.

Will do, I got caught up on a bunch of other stuff finally, so hope to circle back to this one soon.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2026

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2026 •
edited
Loading

Channel deleted.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2026 •
edited
Loading

Test Results

   72 files    496 suites   0s ⏱️
2 738 tests 2 738 ✅ 0 💤 0 ❌
4 614 runs  4 614 ✅ 0 💤 0 ❌

Results for commit b7a24a7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2026 •
edited
Loading

File Coverage
All files 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/multifunctional-siren/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/apiv6_bugfix/can_handle.lua 66% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/aeotec-doorbell-siren/init.lua 85% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/philio-sound-siren/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/zwave-sound-sensor/init.lua 84% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/preferences.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/configurations.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/utilitech-siren/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/yale-siren/init.lua 88% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-siren/src/zipato-siren/init.lua 92% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against b7a24a7

@jtp10181
zwave-siren ZSE50 more fixes
243ec27 
* Merged upstream and updated for lazy-load
* Consolidated tones_list and tones_duration maps as suggested
* Removed debug logs and commented out code
jtp10181 added 3 commits April 5, 2026 15:33
@jtp10181
zwave-siren ZSE50 unit tests
1741417 
* Added units tests
@jtp10181
zwave-siren ZSE50 unit tests fixes
166b6b0 
Removed audioVolume from supported capabilities so main unit test does not fail.
@jtp10181
zwave-siren ZSE50 unit tests fixes
ad0bc7c 
Added more units tests to increase coverage
@jtp10181
Copy link
Copy Markdown
Contributor Author

jtp10181 commented Apr 5, 2026 •
edited
Loading

Hi @jtp10181 let us know when you're ready for a re-review.

Will do, I got caught up on a bunch of other stuff finally, so hope to circle back to this one soon.

Ok @greens, @wkhenon, @cbaumler
I think I have this all squared away now. I believe I addressed all issues and added 24 unit tests to get it to 95%. I think the two failing checks are some sort of issue with the bot itself and not an issue with the code.

I really hate making unit tests so I decided to have Copilot help make then, worked great once I told it to ingest all the other ones in the same folder for examples.

@cbaumler cbaumler requested review from aleclorimer and cjswedes April 6, 2026 15:38
cjswedes
cjswedes reviewed Apr 7, 2026
View reviewed changes
Comment thread drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua
Comment thread drivers/SmartThings/zwave-siren/src/zooz-zse50/init.lua Outdated
@cbaumler cbaumler merged commit 3d88670 into SmartThingsCommunity:main Apr 9, 2026
11 of 13 checks passed
@jtp10181 jtp10181 deleted the zwave-siren_zse50 branch April 10, 2026 23:20
hcarter-775 pushed a commit that referenced this pull request Apr 11, 2026
@jtp10181 @hcarter-775
WWSTCERT-9857 Add Zooz ZSE50 to zwave-siren (for WWST Cert) (#2681)
cf4f98f 
* Add Zooz ZSE50 to zwave-siren
cjswedes pushed a commit that referenced this pull request Apr 15, 2026
@jtp10181 @cjswedes
WWSTCERT-9857 Add Zooz ZSE50 to zwave-siren (for WWST Cert) (#2681)
2016726 
* Add Zooz ZSE50 to zwave-siren
ctowns pushed a commit that referenced this pull request Apr 21, 2026
@jtp10181 @ctowns
WWSTCERT-9857 Add Zooz ZSE50 to zwave-siren (for WWST Cert) (#2681)
1101206 
* Add Zooz ZSE50 to zwave-siren
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjswedes cjswedes cjswedes left review comments

@aleclorimer aleclorimer aleclorimer approved these changes

@cbaumler cbaumler Awaiting requested review from cbaumler

+3 more reviewers

@greens greens greens left review comments

@wkhenon wkhenon wkhenon left review comments

@pegor-karoglanian pegor-karoglanian pegor-karoglanian left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jtp10181 @cbaumler @greens @cjswedes @wkhenon @pegor-karoglanian @aleclorimer