Skip to content

NodOn fingerprint ( WWSTCERT-9497)#2713

Merged
greens merged 7 commits intomainfrom
NodOn_fingerprints
Mar 9, 2026
Merged

NodOn fingerprint ( WWSTCERT-9497)#2713
greens merged 7 commits intomainfrom
NodOn_fingerprints

Conversation

@KKlimczukS
Copy link
Copy Markdown
Contributor

@KKlimczukS KKlimczukS commented Jan 20, 2026 •
edited
Loading

Check all that apply
fingerprint for:

  • NodOn SIN-4-1-20-PRO (WWSTCERT-9497)

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@KKlimczukS KKlimczukS requested a review from greens January 20, 2026 14:51
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 20, 2026 •
edited
Loading

Channel deleted.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 20, 2026 •
edited
Loading

Test Results

   72 files  +  1    489 suites  +9   0s ⏱️ ±0s
2 675 tests +187  2 675 ✅ +187  0 💤 ±0  0 ❌ ±0 
4 523 runs  +252  4 523 ✅ +252  0 💤 ±0  0 ❌ ±0 

Results for commit 7314394. ± Comparison against base commit 2192441.

This pull request removes 3 and adds 190 tests. Note that renamed tests count towards both. 
MaxEncodedPixelRate, VideoSensorParams, Rate Distortion Trade Off Points reports should generate appropriate events
Rate Distortion Trade Off Points, MaxEncodedPixelRate, VideoSensorParams reports should generate appropriate events
Rate Distortion Trade Off Points, VideoSensorParams, MaxEncodedPixelRate reports should generate appropriate events

AQI hazardous (>=301) emits hazardous airQualityHealthConcern
AQI moderate (51-100) emits moderate airQualityHealthConcern
AQI slightlyUnhealthy (101-150) emits slightlyUnhealthy airQualityHealthConcern
AQI unhealthy (151-200) emits unhealthy airQualityHealthConcern
AQI veryUnhealthy (201-300) emits veryUnhealthy airQualityHealthConcern
Added handler should initialize VOC and air quality state
Added handler should send manufacturer attribute and initialize device state
Added lifecycle should emit water dry event
Added lifecycle should read ApplicationVersion
Adding a window treatment device should emit supportedWindowShadeCommands
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 20, 2026 •
edited
Loading

File Coverage
All files 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/frient/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/laisiao/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/frient-IO/init.lua 88% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/frient-IO/unbind_request.lua 71% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/color_temp_range_handlers/init.lua 80% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli/vzm30-sn/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/preferences.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/version/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara-light/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/configurations/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/tuya-multi/can_handle.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli/vzm32-sn/init.lua 95% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7314394

@KKlimczukS KKlimczukS changed the title NodOn fingerprints (WWSTCERT-9430, WWSTCERT-9490, WWSTCERT-9494, WWSTCERT-9497 ) NodOn fingerprints (WWSTCERT-9430, WWSTCERT-9434, WWSTCERT-9490, WWSTCERT-9494, WWSTCERT-9497 ) Jan 22, 2026
@KKlimczukS KKlimczukS changed the title NodOn fingerprints (WWSTCERT-9430, WWSTCERT-9434, WWSTCERT-9490, WWSTCERT-9494, WWSTCERT-9497 ) NodOn fingerprints (WWSTCERT-9490, WWSTCERT-9494, WWSTCERT-9497) Feb 19, 2026
@KKlimczukS KKlimczukS requested a review from greens February 19, 2026 15:58
@KKlimczukS KKlimczukS changed the title NodOn fingerprints (WWSTCERT-9490, WWSTCERT-9494, WWSTCERT-9497) NodOn fingerprint ( WWSTCERT-9497) Mar 5, 2026
@KKlimczukS KKlimczukS requested a review from greens March 5, 2026 15:52
@greens greens merged commit f1ffe32 into main Mar 9, 2026
11 checks passed
@greens greens deleted the NodOn_fingerprints branch March 9, 2026 19:40
cjswedes pushed a commit that referenced this pull request Mar 25, 2026
@KKlimczukS @cjswedes
NodOn fingerprint ( WWSTCERT-9497) (#2713)
416746e 
* NodOn fingerprints

* Fingerprint for NodOn IRB-4-1-00

* removes 2 fingerprints

* removes fingerprint from the PR due to issues with the device

* removes fingerprint from the PR due to issues with the device
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greens greens Awaiting requested review from greens

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KKlimczukS @greens