WWSTCERT-10559/10562/10565/10568 add driver to frient EMI devices by marcintyminski · Pull Request #2730 · SmartThingsCommunity/SmartThingsEdgeDrivers

marcintyminski · 2026-01-26T13:28:33Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

github-actions · 2026-01-26T13:29:00Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2026-01-26T13:29:43Z

Channel deleted.

github-actions · 2026-01-26T13:30:26Z

Test Results

72 files 492 suites 0s ⏱️
2 684 tests 2 684 ✅ 0 💤 0 ❌
4 545 runs 4 545 ✅ 0 💤 0 ❌

Results for commit 00100ba.

♻️ This comment has been updated with latest results.

github-actions · 2026-01-26T13:30:28Z

File	Coverage
All files	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/configurations.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/init.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/init.lua	`93%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 00100ba

greens · 2026-02-05T20:01:33Z

+  raw_value = raw_value * multiplier / divisor * 1000
+
+  -- The result is already in watts, no need to multiply by 1000
+  device:emit_component_event(device.profile.components['main'], capabilities.powerMeter.power({ value = raw_value, unit = "W" }))


when emitting for the main component, you can just use device:emit_event

Also this seems identical to the defaults except for the default value, which you could set elsewhere (like in added) with

device:set_field(zigbee_constants.SIMPLE_METERING_DIVISOR_KEY, SIMPLE_METERING_DEFAULT_DIVISOR)

instead of overriding the default behavior

For some reason the configuration of attribute does not work without this handler here

greens · 2026-02-05T20:25:28Z

+local function instantaneous_demand_handler(driver, device, value, zb_rx)
+  local raw_value = value.value
+  --- demand = demand received * Multipler/Divisor
+  local multiplier = device:get_field(zigbee_constants.SIMPLE_METERING_MULTIPLIER_KEY) or 1
+  local divisor = device:get_field(zigbee_constants.SIMPLE_METERING_DIVISOR_KEY) or SIMPLE_METERING_DEFAULT_DIVISOR
+  if raw_value < -8388607 or raw_value >= 8388607 then
+    raw_value = 0
+  end
+
+  raw_value = raw_value * multiplier / divisor * 1000
+
+  local raw_value_watts = raw_value
+  device:emit_event_for_endpoint(zb_rx.address_header.src_endpoint.value, capabilities.powerMeter.power({ value = raw_value_watts, unit = "W" }))
+end


This also seems functionally the same as the default behavior.

The device sometimes sends weird values, so we added a guard to ignore these values

greens · 2026-02-05T20:25:59Z

+  device:emit_event_for_endpoint(zb_rx.address_header.src_endpoint.value, capabilities.powerMeter.power({ value = raw_value_watts, unit = "W" }))
+end
+
+local function energy_meter_handler(driver, device, value, zb_rx)


what's different between this handler and the sub-driver's version?

It is the same story as with instantaneous_demand_handler. If we delete the function from subdriver the configuration od CurrentSummationDelivered stops working and it only refreshes when we refresh it manually.

greens · 2026-02-19T20:56:11Z

+  device:send(SimpleMetering.attributes.Divisor:read(device))
+  device:send(SimpleMetering.attributes.Multiplier:read(device))


i believe these will be read as part of the default refresh handlers, since they're configured attributes.

They are not included in refresh here. If we delete them, it will never read them and it will use the default value we assigned to zigbee_constants.SIMPLE_METERING_MULTIPLIER_KEY and zigbee_constants.SIMPLE_METERING_DIVISOR_KEY

) * add driver * removed unused variables * Changes according to pr comments * More changes based on pr comments * date changes * Requested changes to categories in profiles and updated tests * fix conflict * remove extra closing parenthesis

add driver

bfabc01

removed unused variables

115fa8e

marcintyminski changed the title ~~add driver~~ add driver to frient EMI devices Jan 27, 2026

KKlimczukS requested a review from greens February 4, 2026 10:43

greens changed the title ~~add driver to frient EMI devices~~ WWSTCERT-10228/10231/10234 add driver to frient EMI devices Feb 5, 2026

greens requested review from pegor-karoglanian and wkhenon February 5, 2026 18:41

greens changed the title ~~WWSTCERT-10228/10231/10234 add driver to frient EMI devices~~ WWSTCERT-10225/10228/10231/10234 add driver to frient EMI devices Feb 5, 2026